linux-kernel - Re: [PATCH] lsm: make keys for static branch static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cbbd4457d76c90179a63a87645c688f0@paul-moore.com>
Date: Tue, 06 Jan 2026 20:57:53 -0500
From: Paul Moore <paul@...l-moore.com>
To: Ben Dooks <ben.dooks@...ethink.co.uk>, linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Cc: serge@...lyn.com, jmorris@...ei.org, paul@...l-moore.co, Ben Dooks <ben.dooks@...ethink.co.uk>
Subject: Re: [PATCH] lsm: make keys for static branch static

On Jan  6, 2026 Ben Dooks <ben.dooks@...ethink.co.uk> wrote:
> 
> The key use for static-branches are not refrenced by name outside
> of the security/security.c file, so make them static. This stops
> the sparse warnings about "Should it be static?" such as:
> 
> security/security.c: note: in included file:
> ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_0' was not declared. Should it be static?
> ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_1' was not declared. Should it be static?
> ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_2' was not declared. Should it be static?
> ./include/linux/lsm_hook_defs.h:30:1: warning: symbol 'security_hook_active_binder_transaction_0' was not declared. Should it be static?
> ...
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
>  security/security.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged into lsm/dev, thanks.

--
paul-moore.com