[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260107144252.74666-1-karthikey3608@gmail.com>
Date: Wed, 7 Jan 2026 20:12:49 +0530
From: Karthikey D Kadati <karthikey3608@...il.com>
To: Hans de Goede <hansg@...nel.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Dan Carpenter <dan.carpenter@...aro.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
linux-media@...r.kernel.org,
linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org,
Karthikey D Kadati <karthikey3608@...il.com>
Subject: [PATCH v3 0/3] media: atomisp: refactoring and fixes for V4L2 compliance
This patch series addresses maintainer feedback and fixes build errors
in the atomisp driver.
Patch 1: Standardizes the 'Bridge' structs significantly by using
v4l2_rect instead of custom shadow structs and aligning ia_css_region
members with V4L2 conventions.
Patch 2: Introduces a helper function for statistics buffer allocation
to reduce code duplication and centralize error handling logic.
Patch 3: Adds missing error propagation for IRQ enable and XNR
configuration to improve robustness.
Changes in v3:
- Fix extra new lines in commit messages (Dan Carpenter).
- Remove unnecessary s32/u32 casts in atomisp_cmd.c, keeping only the
(long long) casts to prevent overflow (Dan Carpenter).
- Propagate error codes in atomisp_ioctl.c instead of returning
hardcoded -ENOMEM (Dan Carpenter).
- Update commit message for Patch 3 to avoid "flooding" terminology
(Dan Carpenter).
- Wrap cover letter and commit messages to 75 characters (Dan Carpenter).
- Sent as a new thread to avoid confusion.
Changes in v2:
- Split into a 3-patch series.
- Standardized internal CSS types.
- Fixed integer overflow safety.
This series is based on the latest staging/next tree and has been
verified with checkpatch.pl --strict.
Karthikey D Kadati (3):
media: atomisp: replace shadow zoom structs with v4l2_rect
media: atomisp: consolidate statistics buffer allocation
media: atomisp: propagate errors from ISP xnr and IRQ enable
.../media/atomisp/include/linux/atomisp.h | 19 +--
.../staging/media/atomisp/pci/atomisp_cmd.c | 142 +++++++++---------
.../staging/media/atomisp/pci/atomisp_ioctl.c | 127 ++++++++++------
.../staging/media/atomisp/pci/ia_css_types.h | 6 +-
.../staging/media/atomisp/pci/sh_css_params.c | 16 +-
5 files changed, 170 insertions(+), 140 deletions(-)
--
2.43.0
Powered by blists - more mailing lists