[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2026010726-grimy-variably-b10e@gregkh>
Date: Wed, 7 Jan 2026 16:01:37 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Akshay Gujar <Akshay.Gujar@...man.com>
Cc: linux-usb@...r.kernel.org, stern@...land.harvard.edu, oneukum@...e.com,
linux-kernel@...r.kernel.org, naveen.v@...man.com,
sankarkumar.krishnasamy@...man.com
Subject: Re: [PATCH v2 0/3] Generic device enumeration failure notification
On Wed, Dec 24, 2025 at 11:58:05AM +0000, Akshay Gujar wrote:
> This series is a revised version of the earlier patch, updated in response
> to review feedback in the discussion starting at:
>
> <2025100805-resisting-target-419a@...gkh>
>
> The intent is to provide a small, generic mechanism for notifying
> userspace when device enumeration fails after hardware is detected but
> before enumeration completes.
>
> Some devices may be detected electrically but fail to enumerate due to
> protocol-level errors or invalid responses. Today, such failures are
> reported only via kernel log messages. This series introduces a
> structured uevent notification that allows userspace to observe these
> failures without embedding policy in the kernel.
>
> Patch overview:
>
> 1/3 driver-core: add device_enumeration_failure_notify() helper
> Adds a generic helper in the driver core to emit a KOBJ_CHANGE
> uevent containing DEVICE_ENUMERATION_FAILURE=<identifier>.
>
> 2/3 Documentation: ABI: document DEVICE_ENUMERATION_FAILURE uevent
> Documents the new uevent and includes an example captured on USB.
>
> 3/3 usb: hub: send enumeration failure uevent
> Uses the generic helper in the USB hub enumeration failure path.
>
> The USB change is intentionally minimal and serves as an initial user of
> the generic helper. Other subsystems may use the helper independently if
> needed.
>
> Akshay Gujar (3):
> driver core: add device_enumeration_failure_notify() helper
> Documentation: ABI: document DEVICE_ENUMERATION_FAILURE uevent
> usb: hub: send enumeration failure uevent
>
> Documentation/ABI/testing/sysfs-uevent | 22 +++++++++++++++++++
> drivers/base/core.c | 30 ++++++++++++++++++++++++++
> drivers/usb/core/hub.c | 5 ++++-
> include/linux/device.h | 12 +++++++++++
> 4 files changed, 68 insertions(+), 1 deletion(-)
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
Powered by blists - more mailing lists