linux-kernel - Re: [PATCH] vmalloc: export vrealloc_node_align

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01d6b029-e641-4029-86cb-43e7de42814c@kernel.org>
Date: Wed, 7 Jan 2026 16:18:48 +0100
From: Danilo Krummrich <dakr@...nel.org>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Uladzislau Rezki <urezki@...il.com>, Miguel Ojeda <ojeda@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Trevor Gross <tmgross@...ch.edu>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] vmalloc: export vrealloc_node_align_noprof



On 1/7/26 4:16 PM, Alice Ryhl wrote:
> This symbol is used from the Nova driver, so it needs to be exported to
> avoid a build failure when building Nova as a module.
> 
> ERROR: modpost: "vrealloc_node_align_noprof" [drivers/gpu/nova-core/nova_core.ko] undefined!
> ERROR: modpost: "vrealloc_node_align_noprof" [samples/rust/rust_dma.ko] undefined!
> 
> This error is only triggered if helpers are inlined into Rust.
> Otherwise, Nova will call the exported symbol
> 
> 	rust_helper_vrealloc_node_align()
> 
> instead. There is no Fixes: tag as that feature is still WIP.
> 
> I used non-GPL EXPORT_SYMBOL to match the rest of the file, but let me
> know if I should use EXPORT_SYMBOL_GPL.
> 
> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>

Reviewed-by: Danilo Krummrich <dakr@...nel.org>