linux-kernel - [PATCH v3 1/4] HID: asus: Replace magic number with HID_UP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260107152213.143247-4-sunlightlinux@gmail.com>
Date: Wed,  7 Jan 2026 17:22:12 +0200
From: "Ionut Nechita (Sunlight Linux)" <sunlightlinux@...il.com>
To: benato.denis96@...il.com,
	jikos@...nel.org,
	bentiss@...nel.org
Cc: ionut_n2001@...oo.com,
	linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	sunlightlinux@...il.com,
	superm1@...nel.org
Subject: [PATCH v3 1/4] HID: asus: Replace magic number with HID_UP_ASUSVENDOR constant

From: Ionut Nechita <ionut_n2001@...oo.com>

Use the existing HID_UP_ASUSVENDOR constant instead of the magic number
0xff310000 for better code clarity and maintainability.

Reviewed-by: Denis Benato <benato.denis96@...il.com>
Signed-off-by: Ionut Nechita <ionut_n2001@...oo.com>
---
 drivers/hid/hid-asus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 472bca54642b9..eb14b9d13823b 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -317,7 +317,7 @@ static int asus_e1239t_event(struct asus_drvdata *drvdat, u8 *data, int size)
 static int asus_event(struct hid_device *hdev, struct hid_field *field,
 		      struct hid_usage *usage, __s32 value)
 {
-	if ((usage->hid & HID_USAGE_PAGE) == 0xff310000 &&
+	if ((usage->hid & HID_USAGE_PAGE) == HID_UP_ASUSVENDOR &&
 	    (usage->hid & HID_USAGE) != 0x00 &&
 	    (usage->hid & HID_USAGE) != 0xff && !usage->type) {
 		hid_warn(hdev, "Unmapped Asus vendor usagepage code 0x%02x\n",
-- 
2.52.0