linux-kernel - Re: [PATCH 1/3] dt-bindings: watchdog: Add support for Andes ATCWDT200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffb1a4ef-b22c-4d59-a494-0ab703ef24d2@kernel.org>
Date: Wed, 7 Jan 2026 16:44:40 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: CL Wang <cl634@...estech.com>, wim@...ux-watchdog.org,
 linux@...ck-us.net, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-watchdog@...r.kernel.org, tim609@...estech.com
Subject: Re: [PATCH 1/3] dt-bindings: watchdog: Add support for Andes
 ATCWDT200

On 07/01/2026 15:50, CL Wang wrote:
> Add the devicetree binding documentation for the Andes ATCWDT200
> watchdog timer, including supported properties and usage examples.

Last part is redundant. Can you add a binding without supported
properties and without usage examples?

> 
> Signed-off-by: CL Wang <cl634@...estech.com>
> ---
>  .../watchdog/andestech,ae350-wdt.yaml         | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml b/Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml
> new file mode 100644
> index 000000000000..4726bd6734d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/andestech,ae350-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Andes ATCWDT200 Watchdog Timer
> +
> +maintainers:
> +  - CL Wang <cl634@...estech.com>
> +
> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - andestech,qilai-wdt
> +          - const: andestech,ae350-wdt
> +      - const: andestech,ae350-wdt

Subject says WDT200, this code sais 350 and qilai. What is what? You
have entire commit msg to explain that
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  andestech,clock-source:

No clue what's this, but for sure does not pass tests without
description and type.

> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - andestech,clock-source
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    watchdog@...00000 {
> +        compatible = "andestech,ae350-wdt";
> +        reg = <0xf0500000 0x20>;
> +        clocks = <&clk_wdt>;
> +        andestech,clock-source = <0>;
> +    };


Best regards,
Krzysztof