linux-kernel - Re: [PATCH 5/5] rust: faux: use "kernel vertical" style for imports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2026010734-darkness-daytime-2795@gregkh>
Date: Wed, 7 Jan 2026 16:09:39 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Danilo Krummrich <dakr@...nel.org>
Cc: rafael@...nel.org, ojeda@...nel.org, boqun.feng@...il.com,
	gary@...yguo.net, bjorn3_gh@...tonmail.com, lossin@...nel.org,
	a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu,
	david.m.ertman@...el.com, ira.weiny@...el.com, leon@...nel.org,
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 5/5] rust: faux: use "kernel vertical" style for imports

On Mon, Jan 05, 2026 at 03:19:46PM +0100, Danilo Krummrich wrote:
> Convert all imports to use "kernel vertical" style.
> 
> With this, subsequent patches neither introduce unrelated changes nor
> leave an inconsistent import pattern.
> 
> While at it, drop unnecessary imports covered by prelude::*.
> 
> Link: https://docs.kernel.org/rust/coding-guidelines.html#imports
> Signed-off-by: Danilo Krummrich <dakr@...nel.org>
> ---
>  rust/kernel/faux.rs | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/rust/kernel/faux.rs b/rust/kernel/faux.rs
> index 7fe2dd197e37..43b4974f48cd 100644
> --- a/rust/kernel/faux.rs
> +++ b/rust/kernel/faux.rs
> @@ -6,8 +6,17 @@
>  //!
>  //! C header: [`include/linux/device/faux.h`](srctree/include/linux/device/faux.h)
>  
> -use crate::{bindings, device, error::code::*, prelude::*};
> -use core::ptr::{addr_of_mut, null, null_mut, NonNull};
> +use crate::{
> +    bindings,
> +    device,
> +    prelude::*, //
> +};
> +use core::ptr::{
> +    addr_of_mut,
> +    null,
> +    null_mut,
> +    NonNull, //
> +};
>  
>  /// The registration of a faux device.
>  ///
> -- 
> 2.52.0
> 

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>