linux-kernel - Re: [PATCH v2 RESEND v2 3/3] media: atomisp: propagate errors from ISP xnr and IRQ enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV5urWWGzYlZr3lo@stanley.mountain>
Date: Wed, 7 Jan 2026 17:33:17 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Karthikey D Kadati <karthikey3608@...il.com>
Cc: Hans de Goede <hansg@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 RESEND v2 3/3] media: atomisp: propagate errors from
 ISP xnr and IRQ enable

On Wed, Jan 07, 2026 at 07:18:44PM +0530, Karthikey D Kadati wrote:
> Propagate the return value of atomisp_css_capture_enable_xnr() in
> 
> atomisp_xnr().
> 
> Also check the return value of atomisp_css_irq_enable() and log an
> 
> error once using dev_err_once() to avoid flooding dmesg.
> 

Leave off the "to avoid flooding dmesg" because otherwise it makes it
sound like we were flooding dmesg before.  Just say:  "Also print an
error message if atomisp_css_irq_enable() fails".

regards,
dan carpenter