linux-kernel - Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260107143935.5757-1-shankari.ak0208@gmail.com>
Date: Wed,  7 Jan 2026 20:09:35 +0530
From: Shankari Anand <shankari.ak0208@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>,
	Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joelagnelf@...dia.com>,
	Christian Brauner <brauner@...nel.org>,
	Carlos Llamas <cmllamas@...gle.com>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Danilo Krummrich <dakr@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>,
	Alexandre Courbot <acourbot@...dia.com>,
	"Rafael J . Wysocki" <rafael@...nel.org>,
	Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Igor Korotin <igor.korotin.linux@...il.com>,
	Michal Wilczynski <m.wilczynski@...sung.com>
Cc: Boqun Feng <boqun.feng@...il.com>,
	Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Trevor Gross <tmgross@...ch.edu>,
	Daniel Almeida <daniel.almeida@...labora.com>,
	Abdiel Janulgue <abdiel.janulgue@...il.com>,
	Robin Murphy <robin.murphy@....com>,
	linux-kernel@...r.kernel.org,
	rust-for-linux@...r.kernel.org,
	Shankari Anand <shankari.ak0208@...il.com>
Subject: Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted

On Sat, Jan 03, 2026 at 05:28:31AM +0100, kernel test robot wrote:
> Hi Shankari,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on staging/staging-next staging/staging-linus rust/rust-next usb/usb-testing usb/usb-next usb/usb-linus next-20251219]
> [cannot apply to linus/master v6.16-rc1]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Shankari-Anand/rust-i2c-Update-ARef-and-AlwaysRefCounted-imports-to-use-sync-aref/20260103-061451
> base:   staging/staging-testing
> patch link:    https://lore.kernel.org/r/20260102202714.184223-5-shankari.ak0208%40gmail.com
> patch subject: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted
> config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260103/202601030523.4eFrzaYI-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260103/202601030523.4eFrzaYI-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202601030523.4eFrzaYI-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> error[E0432]: unresolved import `crate::types::ARef`
>    --> rust/kernel/device/property.rs:17:13
>    |
>    17 |     types::{ARef, Opaque},
>    |             ^^^^ no `ARef` in `types`
>    |
>    = help: consider importing this struct instead:
>    crate::sync::aref::ARef
> --


Hello Miguel and all,

> >> error[E0432]: unresolved import `crate::types::ARef`
>    --> rust/kernel/scatterlist.rs:41:13
>    |
>    41 |     types::{ARef, Opaque},
>    |             ^^^^ no `ARef` in `types`
>    |
>    = help: consider importing this struct instead:
>    crate::sync::aref::ARef
> --

This change has already been made in [1]. Probably it has showed up on the linux-next
recently which has caused the kernel bot to detect the error.


> >> error[E0405]: cannot find trait `AlwaysRefCounted` in module `crate::types`
>    --> rust/kernel/device/property.rs:362:27
>    |
>    362 | unsafe impl crate::types::AlwaysRefCounted for FwNode {
>    |                           ^^^^^^^^^^^^^^^^ not found in `crate::types`
>    |
>    help: consider importing this trait
>    |
>    7   + use crate::sync::aref::AlwaysRefCounted;
>    |
>    help: if you import `AlwaysRefCounted`, refer to it directly
>    |
>    362 - unsafe impl crate::types::AlwaysRefCounted for FwNode {
>    362 + unsafe impl AlwaysRefCounted for FwNode {
>    |
> 
> --

I haven't raised a patch for this file change I suppose. Should I do it in the same patch v3
or put up a separate patch and reference it there?
 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki


Please let me know which one would be appropriate and accordingly I'll send the revised patch.
I'll try to complete this refactoring soon. Sincere apologies that this has been going since quite a while now.

Thanks a lot!

Regards,
Shankari