linux-kernel - Re: [PATCH v2 15/18] rtla: Make stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260107113132.7c05cd53@gandalf.local.home>
Date: Wed, 7 Jan 2026 11:31:32 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Wander Lairson Costa <wander@...hat.com>
Cc: Tomas Glozar <tglozar@...hat.com>, Crystal Wood <crwood@...hat.com>,
 Ivan Pravdin <ipravdin.official@...il.com>, Costa Shulyupin
 <costa.shul@...hat.com>, John Kacur <jkacur@...hat.com>, Tiezhu Yang
 <yangtiezhu@...ngson.cn>, "open list:Real-time Linux Analysis (RTLA) tools"
 <linux-trace-kernel@...r.kernel.org>, "open list:Real-time Linux Analysis
 (RTLA) tools" <linux-kernel@...r.kernel.org>, "open list:BPF
 [MISC]:Keyword:(?:b|_)bpf(?:b|_)" <bpf@...r.kernel.org>
Subject: Re: [PATCH v2 15/18] rtla: Make stop_tracing variable volatile

On Wed, 7 Jan 2026 10:24:43 -0300
Wander Lairson Costa <wander@...hat.com> wrote:

> > In the kernel, this is handled via the READ_ONCE() macro. Perhaps rtla
> > should implement that too.
> >  
> 
> I considered that, but, in this use case, I saw no point because it
> didn't bring any advantage and volatile was simpler.
> Furthermore, as Crystal pointed out, using volatile for variables
> shared with signals is a pretty standard practice.

OK, I've just been broken in by Linus yelling at anyone defining any
variable as volatile ;-)  I now avoid it at all costs, and only have the
locations that need to be volatile defined that way.

-- Steve