linux-kernel - Re: [PATCH 3/6] drm/imx/dw-hdmi: convert to of_drm_find_and_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e87a26d067de694273daaf011a50f1a2e7718f1.camel@pengutronix.de>
Date: Wed, 07 Jan 2026 17:34:47 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>, Andrzej Hajda	
 <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
 Robert Foss <rfoss@...nel.org>, Laurent Pinchart
 <Laurent.pinchart@...asonboard.com>, Jonas Karlman	 <jonas@...boo.se>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Maarten Lankhorst	
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Kevin Hilman <khilman@...libre.com>,
 Jerome Brunet <jbrunet@...libre.com>, Martin Blumenstingl	
 <martin.blumenstingl@...glemail.com>, Shawn Guo <shawnguo@...nel.org>, 
 Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
 <kernel@...gutronix.de>, Fabio Estevam	 <festevam@...il.com>, Chun-Kuang Hu
 <chunkuang.hu@...nel.org>, Matthias Brugger	 <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno	 <angelogioacchino.delregno@...labora.com>, Inki
 Dae <inki.dae@...sung.com>,  Seung-Woo Kim <sw0312.kim@...sung.com>,
 Kyungmin Park <kyungmin.park@...sung.com>, Krzysztof Kozlowski	
 <krzk@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>, Laurent Pinchart	
 <laurent.pinchart+renesas@...asonboard.com>, Tomi Valkeinen	
 <tomi.valkeinen+renesas@...asonboard.com>, Kieran Bingham	
 <kieran.bingham+renesas@...asonboard.com>, Geert Uytterhoeven	
 <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>
Cc: Hui Pu <Hui.Pu@...ealthcare.com>, Thomas Petazzoni
	 <thomas.petazzoni@...tlin.com>, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev, 
	linux-mediatek@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 3/6] drm/imx/dw-hdmi: convert to
 of_drm_find_and_get_bridge()

On Mi, 2026-01-07 at 17:22 +0100, Luca Ceresoli wrote:
> of_drm_find_bridge() is deprecated. Move to its replacement
> of_drm_find_and_get_bridge() which gets a bridge reference, and ensure it
> is put when done.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> ---
>  drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c b/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c
> index 07e5f96202d4..95f629d97bce 100644
> --- a/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c
> +++ b/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c
> @@ -241,7 +241,7 @@ static int dw_hdmi_imx_probe(struct platform_device *pdev)
>  	if (IS_ERR(hdmi->hdmi))
>  		return PTR_ERR(hdmi->hdmi);
>  
> -	hdmi->bridge = of_drm_find_bridge(np);
> +	hdmi->bridge = of_drm_find_and_get_bridge(np);
>  	if (!hdmi->bridge) {
>  		dev_err(hdmi->dev, "Unable to find bridge\n");
>  		dw_hdmi_remove(hdmi->hdmi);

The component_add() error path below this is missing a
drm_bridge_put().

regards
Philipp