linux-kernel - Re: [PATCH v4 2/2] iio: adc: Initial support for AD4134

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV6IP3T3Q3z3aTVa@smile.fi.intel.com>
Date: Wed, 7 Jan 2026 18:22:23 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Marcelo Schmitt <marcelo.schmitt@...log.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	jic23@...nel.org, nuno.sa@...log.com, dlechner@...libre.com,
	andy@...nel.org, Michael.Hennerich@...log.com, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, tomas.melin@...sala.com,
	marcelo.schmitt1@...il.com
Subject: Re: [PATCH v4 2/2] iio: adc: Initial support for AD4134

On Wed, Jan 07, 2026 at 11:47:59AM -0300, Marcelo Schmitt wrote:
> AD4134 is a 24-bit, 4-channel, simultaneous sampling, precision
> analog-to-digital converter (ADC). The device can be managed through SPI or
> direct control of pin logical levels (pin control mode). The AD4134 design
> also features a dedicated bus for ADC sample data output. Though, this
> initial driver for AD4134 only supports usual SPI connections.
> 
> Add basic support for AD4134 that enables single-shot ADC sample read.

I have been on a few weeks leave and do not remember much, but it looks like
this version has all my previous comments being addressed.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

...

> +#include <linux/array_size.h>
> +#include <linux/bitfield.h>

> +#include <linux/bitops.h>

> +#include <linux/bits.h>

No need, as bitops.h implies (and guarantees) that BIT()/GENMASK() are provided
with it.

> +#include <linux/clk.h>
> +#include <linux/crc8.h>
> +#include <linux/delay.h>
> +#include <linux/dev_printk.h>
> +#include <linux/err.h>
> +#include <linux/export.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/iio/iio.h>
> +#include <linux/iio/types.h>
> +#include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/reset.h>
> +#include <linux/spi/spi.h>
> +#include <linux/time.h>
> +#include <linux/types.h>
> +#include <linux/unaligned.h>
> +#include <linux/units.h>

-- 
With Best Regards,
Andy Shevchenko