linux-kernel - Re: [PATCH v2 05/11] rust: macros: use `quote!` for `module!` macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260107175454.6c5e91f5.gary@garyguo.net>
Date: Wed, 7 Jan 2026 17:54:54 +0000
From: Gary Guo <gary@...yguo.net>
To: Tamir Duberstein <tamird@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
 <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl
 <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich
 <dakr@...nel.org>, Luis Chamberlain <mcgrof@...nel.org>, Petr Pavlu
 <petr.pavlu@...e.com>, Daniel Gomez <da.gomez@...nel.org>, Sami Tolvanen
 <samitolvanen@...gle.com>, Aaron Tomlin <atomlin@...mlin.com>,
 rust-for-linux@...r.kernel.org, linux-modules@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/11] rust: macros: use `quote!` for `module!` macro

On Wed, 7 Jan 2026 12:19:26 -0500
Tamir Duberstein <tamird@...il.com> wrote:

> On Wed, Jan 7, 2026 at 11:59 AM Gary Guo <gary@...nel.org> wrote:
> >
> > From: Gary Guo <gary@...yguo.net>
> >
> > This has no behavioural change, but is good for maintainability. With
> > `quote!`, we're no longer using string templates, so we don't need to
> > quote " and {} inside the template anymore. Further more, editors can
> > now highlight the code template.
> >
> > This also improves the robustness as it eliminates the need for string
> > quoting and escaping.
> >
> > Co-developed-by: Benno Lossin <lossin@...nel.org>
> > Signed-off-by: Benno Lossin <lossin@...nel.org>
> > Signed-off-by: Gary Guo <gary@...yguo.net>  
> 
> Are there significant changes here? You didn't pick up my tag.

There're changes related to added `params` which you probably already
noticed.

Best,
Gary