linux-kernel - Re: [PATCH 1/5] gpio: gpio-menz127: drop unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aV6VL5lZkaXBKJ1X@MNI-190>
Date: Wed, 7 Jan 2026 18:17:35 +0100
From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: Javier Rodriguez <josejavier.rodriguez@...gon.com>,
	linux-kernel@...r.kernel.org,
	Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>,
	Linus Walleij <linusw@...nel.org>,
	Bartosz Golaszewski <brgl@...nel.org>, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 1/5] gpio: gpio-menz127: drop unneeded MODULE_ALIAS

On Fri, Jan 02, 2026 at 02:10:47PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 30, 2025 at 10:59:24PM +0100, Javier Rodriguez wrote:
> >    From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
> > 
> >    The MODULE_ALIAS() is redundant since the module alias is now
> >    automatically generated from the MODULE_DEVICE_TABLE().
> > 
> >    Remove the explicit alias.
> > 
> >    No functional change intended.
> 
> The patch is mangled.
> 
> >    Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
> >    Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>
> 
> >    Cc: Linus Walleij <linusw@...nel.org>
> >    Cc: Bartosz Golaszewski <brgl@...nel.org>
> >    Cc: Andy Shevchenko <andriy.shevchenko@...el.com>
> >    Cc: linux-gpio@...r.kernel.org
> 
> Please, move the Cc: list after the '---' line...
> 
> >    Signed-off-by: Jose Javier Rodriguez Barbarin
> >    <dev-josejavier.rodriguez@...gon.com>
> >    ---
> 
> ...here. It will have the same effect on email, but will reduce a noise in the
> Git history.
> 
> ...
> 
> >    The information contained in this message is private and confidential, as
> >    well as any enclosed document/file attached to it and is addressed
> >    exclusively to its recipient. Please if you are not the intended recipient
> >    and have received this message by mistake, notify us of this fact and
> >    delete the message from your system. The copying, dissemination or
> >    disclosure of its content to third parties without the prior written
> >    consent of DUAGON IBERIA S.L. is forbidden. Otherwise, it will violate
> >    current legislation. In accordance with Spanish Data Protection Law 3/2018
> >    and the European Data Protection Regulation 2016/679, we remind you that
> >    your data is processed by DUAGON IBERIA S.L.. You can freely exercise the
> >    rights of access, opposition, rectification, cancellation or suppression,
> >    revocation of consent, portability and limitation of data processing, by
> >    contacting DUAGON IBERIA S.L., Ronda de Europa, 5. Tres Cantos. Madrid,
> >    C.P. 28760. Spain.
> 
> This is not compatible with the Open Source workflow. Please, make sure there
> is no footer in the next version.
> 

This is a bit embarrasing. I forgot to configure git to use tu proper email account.

> ...
> 
> Also, you missed a cover letter. Or send the patches separately as I don't see
> now any evidence of the cross patch dependency.

Yes, I decided to send the patches in a way that was not the best. So I'm going to
send the patches separately for each subsystem.

> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

Thank you so much for your review.

Regards,

Javier R.