linux-kernel - Re: [PATCH] drm/vmwgfx: Fix an error return check in vmw_compat_shader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABQX2QNDpNXuF6YhWjtWdcDriFR8B49sr22Yr+GKO-V6oCFqqg@mail.gmail.com>
Date: Wed, 7 Jan 2026 12:37:01 -0500
From: Zack Rusin <zack.rusin@...adcom.com>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: bcm-kernel-feedback-list@...adcom.com, maarten.lankhorst@...ux.intel.com, 
	mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch, 
	jakob@...are.com, thellstrom@...are.com, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] drm/vmwgfx: Fix an error return check in vmw_compat_shader_add()

On Wed, Dec 24, 2025 at 4:11 AM Haoxiang Li <lihaoxiang@...c.iscas.ac.cn> wrote:
>
> In vmw_compat_shader_add(), the return value check of vmw_shader_alloc()
> is not proper. Modify the check for the return pointer 'res'.
>
> Found by code review and compiled on ubuntu 20.04.
>
> Fixes: 18e4a4669c50 ("drm/vmwgfx: Fix compat shader namespace")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_shader.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> index 69dfe69ce0f8..7ed938710342 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> @@ -923,8 +923,10 @@ int vmw_compat_shader_add(struct vmw_private *dev_priv,
>         ttm_bo_unreserve(&buf->tbo);
>
>         res = vmw_shader_alloc(dev_priv, buf, size, 0, shader_type);
> -       if (unlikely(ret != 0))
> +       if (IS_ERR(res)) {
> +               ret = PTR_ERR(res);
>                 goto no_reserve;
> +       }
>
>         ret = vmw_cmdbuf_res_add(man, vmw_cmdbuf_res_shader,
>                                  vmw_shader_key(user_key, shader_type),
> --
> 2.25.1
>

Thanks, looks good. I pushed it to drm-misc-fixes.

z

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5414 bytes)