linux-kernel - Re: [PATCH 1/1] sched_ext: Add error logging for dsq creation failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BL1PR15MB531447D39DAACF121532E6A8C784A@BL1PR15MB5314.namprd15.prod.outlook.com>
Date: Wed, 7 Jan 2026 17:32:20 +0000
From: Emil Tsalapatis <etsal@...a.com>
To: George Guo <dongtai.guo@...ux.dev>, "tj@...nel.org" <tj@...nel.org>,
        "void@...ifault.com" <void@...ifault.com>,
        "arighi@...dia.com"
	<arighi@...dia.com>,
        "changwoo@...lia.com" <changwoo@...lia.com>
CC: "sched-ext@...ts.linux.dev" <sched-ext@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        George Guo
	<guodongtai@...inos.cn>
Subject: Re: [PATCH 1/1] sched_ext: Add error logging for dsq creation
 failures

Hi George,

(sorry for the formatting, my email client has decided not to indent the email)

________________________________________
From: George Guo <dongtai.guo@...ux.dev>
Sent: Wednesday, January 7, 2026 1:28 AM
To: tj@...nel.org; void@...ifault.com; arighi@...dia.com; changwoo@...lia.com
Cc: sched-ext@...ts.linux.dev; linux-kernel@...r.kernel.org; George Guo
Subject: [PATCH 1/1] sched_ext: Add error logging for dsq creation failures

From: George Guo <guodongtai@...inos.cn>

Add scx_bpf_error() calls when scx_bpf_create_dsq() fails in multiple
schedulers to improve debuggability:

- scx_central.bpf.c: central_init()
- scx_flatcg.bpf.c: fcg_cgroup_init() and fcg_init()
- scx_qmap.bpf.c: qmap_init()
- scx_simple.bpf.c: simple_init()

Signed-off-by: George Guo <guodongtai@...inos.cn>
---

While the change looks correct, is there any benefit to it? 

- Failing to create a dsq will already cause init() to fail with the error code 
from the failed call. In scx_simple in particular, the  change adds no new 
info because the function amounts to a single scx_bpf_create_dsq() call.

- Regressions to scx_bpf_dsq_create() from kernel-side (as opposed to
BPF scheduler-side) changes will be caught by the selftests.

Not opposed to it, just curious what the advantages are.