linux-kernel - Re: [PATCH v2] scsi: ufs: exynos: call phy_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c3c2687-12c8-452d-86d7-78b3168a8f01@acm.org>
Date: Wed, 7 Jan 2026 08:57:25 -0800
From: Bart Van Assche <bvanassche@....org>
To: Peter Griffin <peter.griffin@...aro.org>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-scsi@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 kernel-team@...roid.com, andre.draszik@...aro.org, willmcvicker@...gle.com,
 tudor.ambarus@...aro.org, jyescas@...gle.com
Subject: Re: [PATCH v2] scsi: ufs: exynos: call phy_notify_state() from
 hibern8 callbacks

On 1/7/26 5:51 AM, Peter Griffin wrote:
> +	union phy_notify phystate = {
> +		.ufs_state = PHY_UFS_HIBERN8_EXIT
> +	};

Should this be declared 'static const'?

> +		phy_notify_state(ufs->phy, phystate);

Can you please ask the maintainer of include/linux/phy/phy.h why
phy_notify is a union since it only has a single member? From that
header file:

union phy_notify {
	enum phy_ufs_state ufs_state;
};

> +	union phy_notify phystate = {
> +		.ufs_state = PHY_UFS_HIBERN8_ENTER
> +	};

Same question here: should this be declared 'static const'?

Thanks,

Bart.