linux-kernel - Re: [PATCH] arm64: dts: marvell: Add missing "#phy-cells" to "usb-nop-xceiv"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87h5sxqsh2.fsf@BLaptop.bootlin.com>
Date: Wed, 07 Jan 2026 17:48:25 +0100
From: Gregory CLEMENT <gregory.clement@...tlin.com>
To: "Rob Herring (Arm)" <robh@...nel.org>, Andrew Lunn <andrew@...n.ch>,
 Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: Add missing "#phy-cells" to
 "usb-nop-xceiv"

"Rob Herring (Arm)" <robh@...nel.org> writes:

> The "usb-nop-xceiv" binding requires "#phy-cells" property with a value
> of 0 though it is not really used. Add it where missing from Marvell
> platforms.
>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Applied on mvebu/dt64

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-3720-db.dts                | 1 +
>  arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 1 +
>  arch/arm64/boot/dts/marvell/armada-8040-db.dts                | 2 ++
>  arch/arm64/boot/dts/marvell/cn9130-crb.dtsi                   | 2 ++
>  arch/arm64/boot/dts/marvell/cn9130-db.dtsi                    | 2 ++
>  arch/arm64/boot/dts/marvell/cn9131-db.dtsi                    | 1 +
>  arch/arm64/boot/dts/marvell/cn9132-db.dtsi                    | 2 ++
>  7 files changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-db.dts b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> index bd4e61d5448e..06d4a3a93f84 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> @@ -41,6 +41,7 @@ exp_usb3_vbus: usb3-vbus {
>  
>  	usb3_phy: usb3-phy {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  		vcc-supply = <&exp_usb3_vbus>;
>  	};
>  
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index 97a180c8dcd9..e82284888b9a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -37,6 +37,7 @@ reg_usb3_vbus: usb3-vbus {
>  
>  	usb3_phy: usb3-phy {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  		vcc-supply = <&reg_usb3_vbus>;
>  	};
>  
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> index 21ecb9c12505..c7102f74d4d5 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> @@ -51,6 +51,7 @@ cp0_reg_usb3_1_vbus: cp0-usb3-1-vbus {
>  
>  	cp0_usb3_0_phy: cp0-usb3-0-phy {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  		vcc-supply = <&cp0_reg_usb3_0_vbus>;
>  	};
>  
> @@ -65,6 +66,7 @@ cp1_reg_usb3_0_vbus: cp1-usb3-0-vbus {
>  
>  	cp1_usb3_0_phy: cp1-usb3-0-phy {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  		vcc-supply = <&cp1_reg_usb3_0_vbus>;
>  	};
>  };
> diff --git a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
> index 5e7d6de3cdde..5689a8bdfd03 100644
> --- a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
> @@ -47,10 +47,12 @@ cp0_reg_usb3_vbus1: regulator-2 {
>  
>  	cp0_usb3_0_phy0: usb-phy-1 {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  	};
>  
>  	cp0_usb3_0_phy1: usb-phy-2 {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  		vcc-supply = <&cp0_reg_usb3_vbus1>;
>  	};
>  
> diff --git a/arch/arm64/boot/dts/marvell/cn9130-db.dtsi b/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> index 3cc320f569ad..7156739aa31a 100644
> --- a/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> @@ -50,6 +50,7 @@ cp0_reg_usb3_vbus0: regulator-2 {
>  
>  	cp0_usb3_0_phy0: usb-phy-1 {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  		vcc-supply = <&cp0_reg_usb3_vbus0>;
>  	};
>  
> @@ -64,6 +65,7 @@ cp0_reg_usb3_vbus1: regulator-3 {
>  
>  	cp0_usb3_0_phy1: usb-phy-2 {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  		vcc-supply = <&cp0_reg_usb3_vbus1>;
>  	};
>  
> diff --git a/arch/arm64/boot/dts/marvell/cn9131-db.dtsi b/arch/arm64/boot/dts/marvell/cn9131-db.dtsi
> index 626042fce7e2..26dc91c88677 100644
> --- a/arch/arm64/boot/dts/marvell/cn9131-db.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9131-db.dtsi
> @@ -31,6 +31,7 @@ cp1_reg_usb3_vbus0: regulator-6 {
>  
>  	cp1_usb3_0_phy0: usb-phy-3 {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  		vcc-supply = <&cp1_reg_usb3_vbus0>;
>  	};
>  
> diff --git a/arch/arm64/boot/dts/marvell/cn9132-db.dtsi b/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
> index f91fc69905b8..f82d45e62753 100644
> --- a/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
> @@ -28,6 +28,7 @@ cp2_reg_usb3_vbus0: regulator-7 {
>  
>  	cp2_usb3_0_phy0: usb-phy-4 {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  		vcc-supply = <&cp2_reg_usb3_vbus0>;
>  	};
>  
> @@ -42,6 +43,7 @@ cp2_reg_usb3_vbus1: regulator-8 {
>  
>  	cp2_usb3_0_phy1: usb-phy-5 {
>  		compatible = "usb-nop-xceiv";
> +		#phy-cells = <0>;
>  		vcc-supply = <&cp2_reg_usb3_vbus1>;
>  	};
>  
> -- 
> 2.51.0
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com