[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20260107144739.5847-1-shankari.ak0208@gmail.com>
Date: Wed, 7 Jan 2026 20:17:39 +0530
From: Shankari Anand <shankari.ak0208@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Arve Hjønnevåg <arve@...roid.com>,
Todd Kjos <tkjos@...roid.com>,
Martijn Coenen <maco@...roid.com>,
Joel Fernandes <joelagnelf@...dia.com>,
Christian Brauner <brauner@...nel.org>,
Carlos Llamas <cmllamas@...gle.com>,
Suren Baghdasaryan <surenb@...gle.com>,
Danilo Krummrich <dakr@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>,
Alexandre Courbot <acourbot@...dia.com>,
"Rafael J . Wysocki" <rafael@...nel.org>,
Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
Igor Korotin <igor.korotin.linux@...il.com>,
Michal Wilczynski <m.wilczynski@...sung.com>
Cc: Boqun Feng <boqun.feng@...il.com>,
Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <lossin@...nel.org>,
Andreas Hindborg <a.hindborg@...nel.org>,
Trevor Gross <tmgross@...ch.edu>,
Daniel Almeida <daniel.almeida@...labora.com>,
Abdiel Janulgue <abdiel.janulgue@...il.com>,
Robin Murphy <robin.murphy@....com>,
linux-kernel@...r.kernel.org,
rust-for-linux@...r.kernel.org,
Shankari Anand <shankari.ak0208@...il.com>
Subject: Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted
On Wed, Jan 07, 2026 at 08:09:35PM +0530, Shankari Anand wrote:
>
>
> Hello Miguel and all,
>
> > >> error[E0432]: unresolved import `crate::types::ARef`
> > --> rust/kernel/scatterlist.rs:41:13
> > |
> > 41 | types::{ARef, Opaque},
> > | ^^^^ no `ARef` in `types`
> > |
> > = help: consider importing this struct instead:
> > crate::sync::aref::ARef
> > --
>
> This change has already been made in [1]. Probably it has showed up on the linux-next
> recently which has caused the kernel bot to detect the error.
>
>
> > >> error[E0405]: cannot find trait `AlwaysRefCounted` in module `crate::types`
> > --> rust/kernel/device/property.rs:362:27
> > |
> > 362 | unsafe impl crate::types::AlwaysRefCounted for FwNode {
> > | ^^^^^^^^^^^^^^^^ not found in `crate::types`
> > |
> > help: consider importing this trait
> > |
> > 7 + use crate::sync::aref::AlwaysRefCounted;
> > |
> > help: if you import `AlwaysRefCounted`, refer to it directly
> > |
> > 362 - unsafe impl crate::types::AlwaysRefCounted for FwNode {
> > 362 + unsafe impl AlwaysRefCounted for FwNode {
> > |
> >
> > --
>
> I haven't raised a patch for this file change I suppose. Should I do it in the same patch v3
> or put up a separate patch and reference it there?
>
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
>
>
> Please let me know which one would be appropriate and accordingly I'll send the revised patch.
> I'll try to complete this refactoring soon. Sincere apologies that this has been going since quite a while now.
>
> Thanks a lot!
>
> Regards,
> Shankari
Apologies, I forgot to link [1]
[1] - https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2da67beda68776842fd0a26f2374e42a5e9b12c8
Powered by blists - more mailing lists