linux-kernel - Re: [PATCH 5/6] virt: bao: Move BAO_IPCSHMEM_HYPERCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2026010704-heaviness-quality-f543@gregkh>
Date: Wed, 7 Jan 2026 20:36:55 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: joaopeixoto@...x.tech
Cc: linux-kernel@...r.kernel.org, ajd@...ux.ibm.com, alex@...ti.fr,
	aou@...s.berkeley.edu, bagasdotme@...il.com,
	catalin.marinas@....com, conor+dt@...nel.org, corbet@....net,
	dan.j.williams@...el.com, davidmcerdeira@...x.tech,
	devicetree@...r.kernel.org, dev@...l-k.io, haren@...ux.ibm.com,
	heiko@...ech.de, jose@...x.tech, kever.yang@...k-chips.com,
	krzk+dt@...nel.org, linux-arm-kernel@...ts.infradead.org,
	linux-doc@...r.kernel.org, linux-riscv@...ts.infradead.org,
	maddy@...ux.ibm.com, mani@...nel.org, nathan@...nel.org,
	neil.armstrong@...aro.org, palmer@...belt.com, pjw@...nel.org,
	prabhakar.mahadev-lad.rj@...renesas.com, robh@...nel.org,
	will@...nel.org
Subject: Re: [PATCH 5/6] virt: bao: Move BAO_IPCSHMEM_HYPERCALL_ID to common
 header

On Wed, Jan 07, 2026 at 04:28:28PM +0000, joaopeixoto@...x.tech wrote:
> From: João Peixoto <joaopeixoto@...x.tech>
> 
> Move the IPC shared-memory hypercall ID from architecture-specific
> headers into include/linux/bao.h.

That says _what_ you did, but not why you did it :(

I have no idea why this is needed at all, sorry.

> Signed-off-by: João Peixoto <joaopeixoto@...x.tech>
> ---
>  arch/arm/include/asm/bao.h           | 5 ++---
>  arch/arm64/include/asm/bao.h         | 5 ++---
>  arch/riscv/include/asm/bao.h         | 7 +++----
>  drivers/virt/bao/ipcshmem/ipcshmem.c | 5 +----
>  include/linux/bao.h                  | 3 +++
>  5 files changed, 11 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm/include/asm/bao.h b/arch/arm/include/asm/bao.h
> index 5ece9ecb1455..7d13591fe669 100644
> --- a/arch/arm/include/asm/bao.h
> +++ b/arch/arm/include/asm/bao.h
> @@ -16,14 +16,13 @@
>  #include <linux/arm-smccc.h>
>  #include <linux/bao.h>
>  
> -static inline unsigned long bao_ipcshmem_hypercall(unsigned long hypercall_id,
> -						   unsigned long ipcshmem_id)
> +static inline unsigned long bao_ipcshmem_hypercall(unsigned long ipcshmem_id)

This does not match what you said you were doing in the changelog :(