linux-kernel - Re: [PATCH v1] tracing: Avoid possible signed 64-bit truncation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fUYEDqCUhc+SNpowxJWL4HSV=juxnxNqcZ8mPiPT=SHRg@mail.gmail.com>
Date: Wed, 7 Jan 2026 11:40:51 -0800
From: Ian Rogers <irogers@...gle.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, 
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v1] tracing: Avoid possible signed 64-bit truncation

On Wed, Jan 7, 2026 at 11:26 AM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> On Tue, 9 Dec 2025 21:31:35 -0500
> Steven Rostedt <rostedt@...dmis.org> wrote:
>
> > > ---
> > >  kernel/trace/trace.c | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > > index d1e527cf2aae..e6a80cbe9326 100644
> > > --- a/kernel/trace/trace.c
> > > +++ b/kernel/trace/trace.c
> > > @@ -6057,8 +6057,10 @@ static int cmp_mod_entry(const void *key, const void *pivot)
> > >
> > >     if (addr >= ent[0].mod_addr && addr < ent[1].mod_addr)
> > >             return 0;
> > > +   else if (addr > ent->mod_addr)
> > > +           return 1;
> > >     else
> > > -           return addr - ent->mod_addr;
> > > +           return -1;
> >
> > Could we still keep this down to a single if check?
> >
> >       if (addr < ent->mod_addr)
> >               return -1;
> >
> >       return addr >= ent[1].mod_addr;
>
> Care to send a v2?

Will do, sorry for the delay.

Ian

> -- Steve