linux-kernel - Re: [PATCH] arm64: dts: marvell: change regulator-gpio to regulator-fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878qe9qsck.fsf@BLaptop.bootlin.com>
Date: Wed, 07 Jan 2026 17:51:07 +0100
From: Gregory CLEMENT <gregory.clement@...tlin.com>
To: "Rob Herring (Arm)" <robh@...nel.org>, Andrew Lunn <andrew@...n.ch>,
 Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: change regulator-gpio to
 regulator-fixed

"Rob Herring (Arm)" <robh@...nel.org> writes:

> A "regulator-gpio" must have a GPIO control, hence the name. There's no
> GPIO on a couple of Marvell platforms at least as far as the DT is
> defined, so change the regulator type from GPIO to fixed.
>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Applied on mvebu/dt64

Thanks,

Gregory
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts | 9 ++-------
>  arch/arm64/boot/dts/marvell/cn9131-db-comexpress.dtsi | 3 ++-
>  2 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> index 9f4bafeddd82..a881a3326dba 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> @@ -26,16 +26,11 @@ memory@0 {
>  	};
>  
>  	vcc_sd_reg1: regulator {
> -		compatible = "regulator-gpio";
> +		compatible = "regulator-fixed";
>  		regulator-name = "vcc_sd1";
> -		regulator-min-microvolt = <1800000>;
> +		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
>  		regulator-boot-on;
> -
> -		gpios-states = <0>;
> -		states = <1800000 0x1
> -			3300000 0x0>;
> -		enable-active-high;
>  	};
>  
>  	keys {
> diff --git a/arch/arm64/boot/dts/marvell/cn9131-db-comexpress.dtsi b/arch/arm64/boot/dts/marvell/cn9131-db-comexpress.dtsi
> index 6f3914bcfd01..71c225221617 100644
> --- a/arch/arm64/boot/dts/marvell/cn9131-db-comexpress.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9131-db-comexpress.dtsi
> @@ -15,8 +15,9 @@ / {
>  };
>  
>  &ap0_reg_sd_vccq {
> +	compatible = "regulator-fixed";
>  	regulator-max-microvolt = <1800000>;
> -	states = <1800000 0x1 1800000 0x0>;
> +	/delete-property/ states;
>  	/delete-property/ gpios;
>  };
>  
> -- 
> 2.51.0
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com