linux-kernel - Re: [PATCH][next] ACPI: APEI: EINJ: make read-only array non_mmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ijqOXipqW4APEZb93Vas1ng_J_jXWdc2mrZBg0ZUAZdQ@mail.gmail.com>
Date: Wed, 7 Jan 2026 20:48:54 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Colin Ian King <colin.i.king@...il.com>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>, Tony Luck <tony.luck@...el.com>, 
	Borislav Petkov <bp@...en8.de>, Hanjun Guo <guohanjun@...wei.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Shuai Xue <xueshuai@...ux.alibaba.com>, 
	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org, 
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ACPI: APEI: EINJ: make read-only array
 non_mmio_desc static const

On Fri, Dec 19, 2025 at 11:00 PM Colin Ian King <colin.i.king@...il.com> wrote:
>
> Don't populate the read-only array non_mmio_desc on the stack at run
> time, instead make it static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/acpi/apei/einj-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
> index 305c240a303f..f5bfdffe1e43 100644
> --- a/drivers/acpi/apei/einj-core.c
> +++ b/drivers/acpi/apei/einj-core.c
> @@ -679,7 +679,7 @@ static bool is_allowed_range(u64 base_addr, u64 size)
>          * region intersects with known resource. So do an allow list check for
>          * IORES_DESCs that definitely or most likely not MMIO.
>          */
> -       int non_mmio_desc[] = {
> +       static const int non_mmio_desc[] = {
>                 IORES_DESC_CRASH_KERNEL,
>                 IORES_DESC_ACPI_TABLES,
>                 IORES_DESC_ACPI_NV_STORAGE,
> --

Applied as 6.20 material, thanks!