linux-kernel - Re: [PATCH v3 1/2] HID: intel-ish-hid: loader: Add PRODUCT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5n18nonr-5292-60sr-2634-0q0r870n3oq8@xreary.bet>
Date: Wed, 7 Jan 2026 22:06:34 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Vishnu Sankar <vishnuocv@...il.com>
cc: srinivas.pandruvada@...ux.intel.com, bentiss@...nel.org, corbet@....net, 
    vsankar@...ovo.com, linux-doc@...r.kernel.org, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org, Mark Pearson <mpearson-lenovo@...ebb.ca>, 
    Richie Roy Jayme <rjayme.jp@...il.com>
Subject: Re: [PATCH v3 1/2] HID: intel-ish-hid: loader: Add PRODUCT_FAMILY-based
 firmware  matching

On Mon, 22 Dec 2025, Vishnu Sankar wrote:

> Add support for firmware filenames that include the CRC32 checksum of the
> DMI product_family field. Several OEMs ship ISH firmware variants shared
> across a product family while product_name or product_sku may differ. This
> intermediate matching granularity reduces duplication and improves firmware
> selection for vendor-customized platforms.
> 
> The newly supported filename forms are checked before existing patterns:
> 
>   ish_${gen}_${vendor}_${family}_${name}_${sku}.bin
>   ish_${gen}_${vendor}_${family}_${sku}.bin
>   ish_${gen}_${vendor}_${family}_${name}.bin
>   ish_${gen}_${vendor}_${family}.bin
> 
> The legacy product_name/product_sku rules remain unchanged and continue
> to provide fallback matching.
> 
> ISH_FW_FILENAME_LEN_MAX is changed to 72 to accommodate the product_family.
> 
> Tested with X9 series and X1 series.
> 
> Reviewed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
> Tested-by: Richie Roy Jayme <rjayme.jp@...il.com>
> Signed-off-by: Vishnu Sankar <vishnuocv@...il.com>

Applied both to hid.git#for-6.20/intel-ish, thanks.

-- 
Jiri Kosina
SUSE Labs