linux-kernel - Re: [PATCH v2 1/4] dt-bindings: can: renesas,rcar-canfd: Specify reset-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8uFnm0oJqbkHZURi9vGXxnfG7cvxgZ2GH5b8nYOUohXDw@mail.gmail.com>
Date: Wed, 7 Jan 2026 21:15:46 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>, Vincent Mailhol <mailhol@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Biju Das <biju.das.jz@...renesas.com>, linux-can@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: can: renesas,rcar-canfd: Specify reset-names

Hi Krzysztof,

On Wed, Jan 7, 2026 at 8:25 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 06/01/2026 18:17, Lad, Prabhakar wrote:
> > Hi Krzysztof,
> >
> > Thank you for the review.
> >
> > On Fri, Jan 2, 2026 at 11:16 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >>
> >> On Tue, Dec 30, 2025 at 11:58:11AM +0000, Prabhakar wrote:
> >>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >>>
> >>> Specify the expected reset-names for the Renesas CAN-FD controller on
> >>> RZ/G2L and RZ/G3E SoCs.
> >>
> >> You should explain here from where you got the actual names.
> >>
> >> Otherwise you got following review:
> >>
> >>>
> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >>> ---
> >>> v1->v2:
> >>> - Moved reset-names to top-level properties.
> >>> ---
> >>>  .../bindings/net/can/renesas,rcar-canfd.yaml  | 33 +++++++++++--------
> >>>  1 file changed, 19 insertions(+), 14 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> >>> index e129bdceef84..9bfd4f44e4d4 100644
> >>> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> >>> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> >>> @@ -122,6 +122,11 @@ properties:
> >>>
> >>>    resets: true
> >>>
> >>> +  reset-names:
> >>> +    items:
> >>> +      - const: rstp_n
> >>> +      - const: rstc_n
> >>
> >> rst seems redundant. _n as well. Are these names from datasheet? How are
> >> they called in this device (not the soc) datasheet exactly? Because it
> >> feels you use pin or SoC names which is not useful.
> >>
> > rstp_n/rstc_n are coming from the SoC HW manual and is already used by
> > the driver (since commit 76e9353a80e9 "can: rcar_canfd: Add support
> > for RZ/G2L family"). The reset-names existed previously but were
> > dropped as of commit 466c8ef7b66b "dt-bindings: can:
> > renesas,rcar-canfd: Simplify the conditional schema". Let me know if
> > you want me to rename them but the driver will have to maintain the
>
> No, I want to follow my first comment in my reply.
>
Ok. As replied to Rob earlier I'll include the below info in the commit message:

The reset names rstp_n and rstc_n are defined in the SoC hardware
manual and are already used by the driver (since commit 76e9353a80e9
"can: rcar_canfd: Add support for RZ/G2L family"). The reset-names
property existed previously but was dropped in commit 466c8ef7b66b
"dt-bindings: can: renesas,rcar-canfd: Simplify the conditional
schema".

Cheers,
Prabhakar