linux-kernel - Re: [PATCH RFC v2 1/3] drm: client: add splash client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aV7eF5C_yUGAfdRe@bywater>
Date: Wed, 7 Jan 2026 23:28:39 +0100
From: Francesco Valla <francesco@...la.it>
To: "Mario Limonciello (AMD) (kernel.org)" <superm1@...nel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Jonathan Corbet <corbet@....net>,
	Jocelyn Falempe <jfalempe@...hat.com>,
	Javier Martinez Canillas <javierm@...hat.com>,
	Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linux-doc@...r.kernel.org,
	linux-embedded@...r.kernel.org
Subject: Re: [PATCH RFC v2 1/3] drm: client: add splash client

On Tue, Jan 06, 2026 at 08:40:46PM -0600, Mario Limonciello (AMD) (kernel.org) wrote:
> > > Yes, that's the idea. I am still searching a EFI-enabled platform I can
> > > perform some proper tests on, as I'm not really familiar with EFI.
> > > This version was tested with OVMF on QEMU, but without a real userspace.
> > 
> > Almost any modern x86 platform except for a chromebook uses EFI.
> > 
> > I'll add them to my local dev tree and test too and see if I can get you
> > some feedback if I run into any problems.
> > 
> From my side when testing I hit this during kernel build:
> 
> ERROR: modpost: "bgrt_tab" [drivers/gpu/drm/clients/drm_client_lib.ko]
> undefined!
> ERROR: modpost: "bgrt_image_size"
> [drivers/gpu/drm/clients/drm_client_lib.ko] undefined!
>

I got the dependency wrong there, mistrusting the efifb driver (but I
should have checked). I made CONFIG_DRM_CLIENT_SPLASH_SRC_BGRT dependent
on CONFIG_EFI, while it should depend on CONFIG_ACPI_BGRT (which in turn
depends on CONFIG_EFI). I'll fix in the next revision (if the overall
work is deemed useful).

Also, please note that the current version is not considering the x/y
offset provided by the BGRT, nor the associated quirks and sanity
checks.

Thank you

Regards,
Francesco