linux-kernel - Re: [PATCH v4 2/3] media: i2c: ov5647: Switch to using the sub-device state lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV7gT5j5JVheV6WW@kekkonen.localdomain>
Date: Thu, 8 Jan 2026 00:38:07 +0200
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Xiaolei Wang <xiaolei.wang@...driver.com>
Cc: tarang.raval@...iconsignals.io, laurent.pinchart@...asonboard.com,
	dave.stevenson@...pberrypi.com, jacopo@...ndi.org,
	mchehab@...nel.org, prabhakar.mahadev-lad.rj@...renesas.com,
	hverkuil+cisco@...nel.org, johannes.goede@....qualcomm.com,
	hverkuil-cisco@...all.nl, jai.luthra@...asonboard.com,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] media: i2c: ov5647: Switch to using the
 sub-device state lock

Hi Xiaolei,

On Thu, Jan 01, 2026 at 06:30:00PM +0800, Xiaolei Wang wrote:
> @@ -1297,9 +1285,16 @@ static int ov5647_probe(struct i2c_client *client)
>  	if (ret < 0)
>  		goto power_off;
>  
> +	sd->state_lock = sensor->ctrls.lock;
> +	ret = v4l2_subdev_init_finalize(sd);
> +	if (ret < 0) {
> +		ret = dev_err_probe(dev, ret, "failed to init subdev\n");
> +		goto power_off;
> +	}
> +
>  	ret = v4l2_async_register_subdev(sd);

v4l2_async_register_subdev() needs to be called before enabling Runtime PM
below. Not a fault of this patch but it'd be nice to fix that. 

>  	if (ret < 0)
> -		goto power_off;
> +		goto v4l2_subdev_cleanup;
>  
>  	/* Enable runtime PM and turn off the device */
>  	pm_runtime_set_active(dev);

The first patch doesn't seem to apply; I've taken earlier a set of ov5647
patches from Dave, could you rebase this on them? They're in my "cleanup"
branch here
<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=cleanup>.

-- 
Kind regards,

Sakari Ailus