linux-kernel - Re: [PATCH net-next v09 2/9] hinic3: Add PF management interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260107031413.941-1-gongfan1@huawei.com>
Date: Wed, 7 Jan 2026 11:14:13 +0800
From: Fan Gong <gongfan1@...wei.com>
To: <gongfan1@...wei.com>
CC: <Markus.Elfring@....de>, <alok.a.tiwari@...cle.com>,
	<andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<guoxin09@...wei.com>, <horms@...nel.org>, <kuba@...nel.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<luosifu@...wei.com>, <luoyang82@...artners.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <pavan.chebbi@...adcom.com>, <shijing34@...wei.com>,
	<wulike1@...wei.com>, <zhoushuai28@...wei.com>, <zhuyikai1@...artners.com>
Subject: Re: [PATCH net-next v09 2/9] hinic3: Add PF management interfaces

> > +static void hinic3_init_mgmt_msg_work(struct hinic3_msg_pf_to_mgmt *pf_to_mgmt,
> > +				      struct hinic3_recv_msg *recv_msg)
> > +{
> > +	struct mgmt_msg_handle_work *mgmt_work;
> > +
> > +	mgmt_work = kmalloc(sizeof(*mgmt_work), GFP_KERNEL);
> > +	if (!mgmt_work)
> > +		return;
> > +
> > +	if (recv_msg->msg_len) {
> > +		mgmt_work->msg = kmalloc(recv_msg->msg_len, GFP_KERNEL);
> > +		if (!mgmt_work->msg) {
> > +			kfree(mgmt_work);
> > +			return;
> > +		}
> > +	}
> 
> When recv_msg->msg_len is zero, the above conditional is not taken, leaving
> mgmt_work->msg uninitialized. The work handler later calls kfree() on this
> uninitialized pointer at the "out" label in hinic3_recv_mgmt_msg_work_handler().
> 
> A zero-length message can arrive when seg_len is 0 in hinic3_recv_msg_add_seg(),
> which only validates seg_len > MGMT_SEG_LEN_MAX but does not reject seg_len == 0.
> 
> Should mgmt_work->msg be initialized to NULL before the conditional, or should
> an else clause set it to NULL?

We will address the AI review comments in patch 2/5/8 sooner.