linux-kernel - Re: [PATCH] lib/crypto: tests: Fix syntax error for old python versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260107033018.GA2283@sol>
Date: Tue, 6 Jan 2026 19:30:18 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Jie Zhan <zhanjie9@...ilicon.com>
Cc: ardb@...nel.org, dhowells@...hat.com, linux-kernel@...r.kernel.org,
	linuxarm@...wei.com, jonathan.cameron@...wei.com
Subject: Re: [PATCH] lib/crypto: tests: Fix syntax error for old python
 versions

On Wed, Jan 07, 2026 at 09:58:29AM +0800, Jie Zhan wrote:
> 'make binrpm-pkg' throws me this error, with Python 3.9:
> 
> *** Error compiling '.../gen-hash-testvecs.py'...
>   File ".../scripts/crypto/gen-hash-testvecs.py", line 121
>     return f'{alg.upper().replace('-', '_')}_DIGEST_SIZE'
>                                    ^
> SyntaxError: f-string: unmatched '('
> 
> Old python versions, presumably <= 3.11, can't resolve these quotes.
> 
> Fix it with double quotes for compatibility.
> 
> Fixes: 15c64c47e484 ("lib/crypto: tests: Add SHA3 kunit tests")
> Signed-off-by: Jie Zhan <zhanjie9@...ilicon.com>
> ---
>  scripts/crypto/gen-hash-testvecs.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'll apply this, but it's weird that 'make binrpm-pkg' is doing anything
with this script.  It's not executed during the kernel build process.
It's only run manually to generate some files that are checked in
elsewhere in the tree.

- Eric