linux-kernel - Re: [PATCH] lib/crypto: tests: polyval_kunit: Increase iterations for preparekey in IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260107040648.GD2283@sol>
Date: Tue, 6 Jan 2026 20:06:48 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>,
	Ard Biesheuvel <ardb@...nel.org>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/crypto: tests: polyval_kunit: Increase iterations
 for preparekey in IRQs

On Mon, Jan 05, 2026 at 09:21:32AM +0100, Thomas Weißschuh wrote:
> On Fri, Jan 02, 2026 at 10:27:48AM -0800, Eric Biggers wrote:
> > On Fri, Jan 02, 2026 at 08:32:03AM +0100, Thomas Weißschuh wrote:
> > > On my development machine the generic, memcpy()-only implementation of
> > > polyval_preparekey() is too fast for the IRQ workers to actually fire.
> > > The test fails.
> > > 
> > > Increase the iterations to make the test more robust.
> > > The test will run for a maximum of one second in any case.
> > > 
> > > Fixes: b3aed551b3fc ("lib/crypto: tests: Add KUnit tests for POLYVAL")
> > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> > 
> > Glad to see that people are running these tests!  I actually already
> > applied
> > https://lore.kernel.org/linux-crypto/20251219085259.1163048-1-davidgow@google.com/
> > for this issue, which should be sufficient by itself.
> 
> That works, too. Thanks!
> 
> > Might be worth
> > increasing the iteration count as well, but I'd like to check whether
> > any other tests could use a similar change as well.
> 
> No other one of the default tests failed for me in a similar way.
> 
> 
> Thomas

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-fixes

I added the following note to the commit message:

   [EB: This failure was already fixed by commit c31f4aa8fed0 ("kunit:
    Enforce task execution in {soft,hard}irq contexts").  I'm still applying
    this patch too, since the iteration count in this test made its running
    time much shorter than the other similar ones.]

- Eric