linux-kernel - Re: [PATCH 4/7] ext4: propagate flags to ext4_convert_unwritten_extents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV4EPQoHD0BMoFnf@li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com>
Date: Wed, 7 Jan 2026 12:29:43 +0530
From: Ojaswin Mujoo <ojaswin@...ux.ibm.com>
To: Zhang Yi <yi.zhang@...weicloud.com>
Cc: linux-ext4@...r.kernel.org, "Theodore Ts'o" <tytso@....edu>,
        Ritesh Harjani <ritesh.list@...il.com>, Jan Kara <jack@...e.cz>,
        libaokun1@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7] ext4: propagate flags to
 ext4_convert_unwritten_extents_endio()

On Wed, Jan 07, 2026 at 02:33:36PM +0800, Zhang Yi wrote:
> Hi, Ojaswin!
> 
> On 1/4/2026 8:19 PM, Ojaswin Mujoo wrote:
> > Currently, callers like ext4_convert_unwritten_extents() pass
> > EXT4_EX_NOCACHE flag to avoid caching extents however this is not
> > respected by ext4_convert_unwritten_extents_endio(). Hence, modify it to
> > accept flags from the caller and to pass the flags on to other extent
> > manipulation functions it calls. This makes sure the NOCACHE flag is
> > respected throughout the code path.
> > 
> > Also, since the caller already passes METADATA_NOFAIL and CONVERT flags
> > we don't need to explicitly pass it anymore.
> 
> Thank you for the refactor! One comment below.
> 
> > 
> > Signed-off-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com>
> > ---
> >  fs/ext4/extents.c | 7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> > 
> > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> > index 5228196f5ad4..460a70e6dae0 100644
> > --- a/fs/ext4/extents.c
> > +++ b/fs/ext4/extents.c
> > @@ -3785,7 +3785,7 @@ static struct ext4_ext_path *ext4_split_convert_extents(handle_t *handle,
> >  static struct ext4_ext_path *
> >  ext4_convert_unwritten_extents_endio(handle_t *handle, struct inode *inode,
> >  				     struct ext4_map_blocks *map,
> > -				     struct ext4_ext_path *path)
> > +				     struct ext4_ext_path *path, int flags)
> >  {
> >  	struct ext4_extent *ex;
> >  	ext4_lblk_t ee_block;
> > @@ -3802,9 +3802,6 @@ ext4_convert_unwritten_extents_endio(handle_t *handle, struct inode *inode,
> >  		  (unsigned long long)ee_block, ee_len);
> >  
> >  	if (ee_block != map->m_lblk || ee_len > map->m_len) {
> > -		int flags = EXT4_GET_BLOCKS_CONVERT |
> > -			    EXT4_GET_BLOCKS_METADATA_NOFAIL;
> > -
> >  		path = ext4_split_convert_extents(handle, inode, map, path,
> >  						  flags, NULL);
> >  		if (IS_ERR(path))
> 
> There is another instance of ext4_find_extent() below that does not respect
> the EXT4_EX_NOCACHE flag. I think we should pass the flag as well.
> 
> Thanks,
> Yi.

Hey Yi, thanks for the review.

Yes you are right, its removed in later commits but for completeness
I'll add it there. 

Thanks,
ojaswin

> 
> > @@ -3943,7 +3940,7 @@ ext4_ext_handle_unwritten_extents(handle_t *handle, struct inode *inode,
> >  	/* IO end_io complete, convert the filled extent to written */
> >  	if (flags & EXT4_GET_BLOCKS_CONVERT) {
> >  		path = ext4_convert_unwritten_extents_endio(handle, inode,
> > -							    map, path);
> > +							    map, path, flags);
> >  		if (IS_ERR(path))
> >  			return path;
> >  		ext4_update_inode_fsync_trans(handle, inode, 1);
>