linux-kernel - Re: Fw: [PATCH 2/2] Bluetooth: hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <baa1a047-0866-4e5f-b550-97d43d825c8c@oss.qualcomm.com>
Date: Wed, 7 Jan 2026 12:50:19 +0530
From: Vivek Sahu <vivek.sahu@....qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Marcel Holtmann <marcel@...tmann.org>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Rob Herring
 <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        "Balakrishna Godavarthi (QUIC)" <quic_bgodavar@...cinc.com>,
        "Rocky Liao (QUIC)" <quic_rjliao@...cinc.com>,
        "Mohammed Sameer Mulla (QUIC)" <quic_mohamull@...cinc.com>,
        "Harish Bandi (QUIC)" <quic_hbandi@...cinc.com>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        quic_janathot@...cinc.com
Subject: Re: Fw: [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement

> From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> Sent: 17 December 2025 19:59
> To: Vivek Sahu <vivesahu@....qualcomm.com>
> Cc: Marcel Holtmann <marcel@...tmann.org>; Luiz Augusto von Dentz <luiz.dentz@...il.com>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Bartosz Golaszewski <brgl@...ev.pl>; Balakrishna Godavarthi (QUIC) <quic_bgodavar@...cinc.com>; Rocky Liao (QUIC) <quic_rjliao@...cinc.com>; Mohammed Sameer Mulla (QUIC) <quic_mohamull@...cinc.com>; Harish Bandi (QUIC) <quic_hbandi@...cinc.com>; linux-bluetooth@...r.kernel.org <linux-bluetooth@...r.kernel.org>; devicetree@...r.kernel.org <devicetree@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; linux-arm-msm@...r.kernel.org <linux-arm-msm@...r.kernel.org>
> Subject: Re: [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement
>
> On Wed, Dec 17, 2025 at 04:58:50PM +0530, Vivek Kumar Sahu wrote:
>> Adding support for BT SoC QCC2072.
>> Set appropriate configurations for BT UART
>> transport.
> Read Documentation/process/submitting-patches.rst


I'll make the commit message more clear in the next patch set of this 
commit.


>
>> Signed-off-by: Vivek Kumar Sahu <vivesahu@....qualcomm.com>
>> ---
>>   drivers/bluetooth/btqca.c   |  8 ++++++++
>>   drivers/bluetooth/btqca.h   |  1 +
>>   drivers/bluetooth/hci_qca.c | 17 +++++++++++++++++
>>   3 files changed, 26 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>> index 7c958d6065be..7eb095db4a1d 100644
>> --- a/drivers/bluetooth/btqca.c
>> +++ b/drivers/bluetooth/btqca.c
>> @@ -854,6 +854,10 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
>>                         snprintf(config.fwname, sizeof(config.fwname),
>>                                  "qca/hmtbtfw%02x.tlv", rom_ver);
>>                         break;
>> +             case QCA_QCC2072:
> Please keep the file sorted. Find a correct place to insert your changes
> rather than randomly sticking them to the end. This applies to _all_ the
> changes you've made here.


I'll address this in the next patch set of this commit.

>
>> +                     snprintf(config.fwname, sizeof(config.fwname),
>> +                              "qca/ornbtfw%02x.tlv", rom_ver);
> I hope to see the firmware being submitted to linux-firmware.


"YES", firmware is being submitted.


>
>> +                     break;
>>                 default:
>>                         snprintf(config.fwname, sizeof(config.fwname),
>>                                  "qca/rampatch_%08x.bin", soc_ver);
>> @@ -929,6 +933,10 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
>>                         qca_get_nvm_name_by_board(config.fwname, sizeof(config.fwname),
>>                                  "hmtnv", soc_type, ver, rom_ver, boardid);
>>                         break;
>> +             case QCA_QCC2072:
>> +                     snprintf(config.fwname, sizeof(config.fwname),
>> +                              "qca/ornnv%02x.bin", rom_ver);
> No board-specific NVMEM dumps?


"NO", for this BT SoC there is no board specific NVM.


>
>> +                     break;
>>                 default:
>>                         snprintf(config.fwname, sizeof(config.fwname),
>>                                  "qca/nvm_%08x.bin", soc_ver);
> --
> With best wishes
> Dmitry