linux-kernel - Re: [PATCH 0/2] Add Apple Silicon SMC power driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEg-Je--qfftNtPgOOU5hsG=6roPeycgSWC+cZkW8EHmLwRx8Q@mail.gmail.com>
Date: Wed, 7 Jan 2026 02:27:35 -0500
From: Neal Gompa <neal@...pa.dev>
To: michael.reeves077@...il.com
Cc: Sebastian Reichel <sre@...nel.org>, Sven Peter <sven@...nel.org>, Janne Grunau <j@...nau.net>, 
	Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, 
	asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	Hector Martin <marcan@...can.st>
Subject: Re: [PATCH 0/2] Add Apple Silicon SMC power driver

On Mon, Jan 5, 2026 at 7:56 AM Michael Reeves via B4 Relay
<devnull+michael.reeves077.gmail.com@...nel.org> wrote:
>
> This series adds a power supply driver for the Apple SMC found on
> Apple Silicon devices. This allows the kernel to report AC status,
> battery charging status, and power metrics, and modify the charging
> behaviour.
>
> The first patch adds the driver itself, and the second patch wires it
> up to the MFD core.
>
> The driver is based on an original out-of-tree implementation by
> Hector Martin. It has been refactored for upstream inclusion,
> including support for newer SMC firmwares, devices without batteries,
> dynamic property detection and improved state management.
>
> Tested on: Apple M3 (MacBook Air, J613)
>
> Signed-off-by: Michael Reeves <michael.reeves077@...il.com>
> ---
> Michael Reeves (2):
>       power: supply: Add macsmc-power driver for Apple Silicon
>       mfd: macsmc: Wire up Apple SMC power driver
>
>  MAINTAINERS                         |   1 +
>  drivers/mfd/macsmc.c                |   1 +
>  drivers/power/supply/Kconfig        |  11 +
>  drivers/power/supply/Makefile       |   1 +
>  drivers/power/supply/macsmc-power.c | 872 ++++++++++++++++++++++++++++++++++++
>  5 files changed, 886 insertions(+)
> ---
> base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
> change-id: 20260105-b4-macsmc-power-d017cc7f53ac
>

LGTM, thanks for this work!

Reviewed-by: Neal Gompa <neal@...pa.dev>


-- 
真実はいつも一つ！/ Always, there's only one truth!