linux-kernel - [RFC PATCH] fs/dlm/dir: remove unuse varible count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260107073015.16562-1-alexs@kernel.org>
Date: Wed,  7 Jan 2026 15:30:14 +0800
From: alexs@...nel.org
To: Alexander Aring <aahringo@...hat.com>,
	David Teigland <teigland@...hat.com>,
	gfs2@...ts.linux.dev (open list:DISTRIBUTED LOCK MANAGER (DLM)),
	linux-kernel@...r.kernel.org (open list)
Cc: Alex Shi <alexs@...nel.org>,
	gfs2@...ts.linux.dev
Subject: [RFC PATCH] fs/dlm/dir: remove unuse varible count_match

From: Alex Shi <alexs@...nel.org>

The variable was never used after introduced. Better to comment it if we
want to keep the info.

fs/dlm/dir.c:65:26: error: variable 'count_match' set but not used [-Werror,-Wunused-but-set-variable]
   65 |         unsigned int count = 0, count_match = 0, count_bad = 0, count_add = 0;
      |                                 ^
1 error generated.

Signed-off-by: Alex Shi <alexs@...nel.org>
Cc: gfs2@...ts.linux.dev
Cc: Alexander Aring <aahringo@...hat.com>
Cc: David Teigland <teigland@...hat.com>
---
 fs/dlm/dir.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/dlm/dir.c b/fs/dlm/dir.c
index b1ab0adbd9d0..01c292379f5b 100644
--- a/fs/dlm/dir.c
+++ b/fs/dlm/dir.c
@@ -62,7 +62,7 @@ int dlm_recover_directory(struct dlm_ls *ls, uint64_t seq)
 	char *b, *last_name = NULL;
 	int error = -ENOMEM, last_len, nodeid, result;
 	uint16_t namelen;
-	unsigned int count = 0, count_match = 0, count_bad = 0, count_add = 0;
+	unsigned int count = 0, count_bad = 0, count_add = 0;
 
 	log_rinfo(ls, "dlm_recover_directory");
 
@@ -157,12 +157,12 @@ int dlm_recover_directory(struct dlm_ls *ls, uint64_t seq)
 				}
 
 				/* The name was found in rsbtbl, and the
-				 * master nodeid matches memb->nodeid. */
+				 * master nodeid matches memb->nodeid.
 
 				if (result == DLM_LU_MATCH &&
 				    nodeid == memb->nodeid) {
 					count_match++;
-				}
+				}*/
 
 				/* The name was not found in rsbtbl and was
 				 * added with memb->nodeid as the master. */
-- 
2.43.0