linux-kernel - Re: [PATCH 04/11] fat: cleanup the flags for fat_truncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260107074346.GA18258@lst.de>
Date: Wed, 7 Jan 2026 08:43:46 +0100
From: Christoph Hellwig <hch@....de>
To: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc: Christoph Hellwig <hch@....de>, Christian Brauner <brauner@...nel.org>,
	Al Viro <viro@...iv.linux.org.uk>, David Sterba <dsterba@...e.com>,
	Jan Kara <jack@...e.cz>, Mike Marshall <hubcap@...ibond.com>,
	Martin Brandenburg <martin@...ibond.com>,
	Carlos Maiolino <cem@...nel.org>, Stefan Roesch <shr@...com>,
	Jeff Layton <jlayton@...nel.org>,
	Trond Myklebust <trondmy@...nel.org>,
	Anna Schumaker <anna@...nel.org>, linux-kernel@...r.kernel.org,
	linux-btrfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	gfs2@...ts.linux.dev, io-uring@...r.kernel.org,
	devel@...ts.orangefs.org, linux-unionfs@...r.kernel.org,
	linux-mtd@...ts.infradead.org, linux-xfs@...r.kernel.org,
	linux-nfs@...r.kernel.org
Subject: Re: [PATCH 04/11] fat: cleanup the flags for fat_truncate_time

On Wed, Jan 07, 2026 at 02:55:06AM +0900, OGAWA Hirofumi wrote:
> > Thanks.
> 
> Ah, I was overlooking that new value is using same value with S_*.

Still not a good idea to not create a bisection hazard.  I've added
a local fat_flags variable and a translation for this patch, even
if that will go away in the next patch to be 100% sane.

> Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

But I've kept the ACK.  Let me know if I should drop it for now with
the change instead.