linux-kernel - Re: [PATCH] perf build: Raise minimum shellcheck version to 0.7.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260107-transparent-ocelot-of-elevation-e7d336@l-nschier-aarch64>
Date: Wed, 7 Jan 2026 09:07:56 +0100
From: Nicolas Schier <nschier-oss@....de>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@...aro.org>,
	Michael Petlan <mpetlan@...hat.com>,
	Jakub Brnak <jbrnak@...hat.com>,
	Veronika Molnarova <vmolnaro@...hat.com>,
	Philipp Hahn <p.hahn@....de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nicolas Schier <nsc@...nel.org>
Subject: Re: [PATCH] perf build: Raise minimum shellcheck version to 0.7.2

On Tue, Jan 06, 2026 at 11:36:59PM -0800, Namhyung Kim wrote:
> On Tue, Jan 06, 2026 at 02:19:28PM +0100, Nicolas Schier wrote:
> > Raise the minimum shellcheck version for perf builds to 0.7.2, so that
> > systems with shellcheck versions below 0.7.2 will automatically skip the
> > shell script checking, even if NO_SHELLCHECK is unset.
> > 
> > Since commit 241f21be7d0f ("perf test perftool_testsuite: Use absolute
> > paths"), shellcheck versions before 0.7.2 break the perf build with
> > several SC1090 [2] warnings due to its too strict dynamic source
> > handling [1].
> 
> It'd be nice if you could copy the error message here.

Sure.  I'll send v2 with one of the messages included here.

> > 
> > Fixes: 241f21be7d0f ("perf test perftool_testsuite: Use absolute paths")
> > Link: https://github.com/koalaman/shellcheck/issues/1998 # [1]
> > Link: https://www.shellcheck.net/wiki/SC1090
> > Signed-off-by: Nicolas Schier <n.schier@....de>
> 
> Other than that,
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks.

Kind regards,
Nicolas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)