linux-kernel - [PATCH] gpio: line-mux: remove bits already handled by GPIO core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260107085833.17338-1-bartosz.golaszewski@oss.qualcomm.com>
Date: Wed,  7 Jan 2026 09:58:33 +0100
From: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
To: Jonas Jelonek <jelonek.jonas@...il.com>, Linus Walleij <linusw@...nel.org>,
        Bartosz Golaszewski <brgl@...nel.org>,
        Thomas Richard <thomas.richard@...tlin.com>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>,
        Dan Carpenter <dan.carpenter@...aro.org>
Subject: [PATCH] gpio: line-mux: remove bits already handled by GPIO core

GPIO core already handles checking the offset against the number of
GPIOs as well as missing any of the GPIO chip callbacks. Remove the
unnecessary bits.

Also, the offset check was off-by-one as reported by Dan.

Fixes: 2b03d9a40cd1 ("gpio: add gpio-line-mux driver")
Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
Closes: https://lore.kernel.org/all/aV4b6GAGz1zyf8Xy@stanley.mountain/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
---
 drivers/gpio/gpio-line-mux.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpio/gpio-line-mux.c b/drivers/gpio/gpio-line-mux.c
index a4f384306218..62548fbd3ca0 100644
--- a/drivers/gpio/gpio-line-mux.c
+++ b/drivers/gpio/gpio-line-mux.c
@@ -29,9 +29,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsigned int offset)
 	struct gpio_lmux *glm = gpiochip_get_data(gc);
 	int ret;
 
-	if (offset > gc->ngpio)
-		return -EINVAL;
-
 	ret = mux_control_select_delay(glm->mux, glm->gpio_mux_states[offset],
 				       MUX_SELECT_DELAY_US);
 	if (ret < 0)
@@ -42,12 +39,6 @@ static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsigned int offset)
 	return ret;
 }
 
-static int gpio_lmux_gpio_set(struct gpio_chip *gc, unsigned int offset,
-			      int value)
-{
-	return -EOPNOTSUPP;
-}
-
 static int gpio_lmux_gpio_get_direction(struct gpio_chip *gc,
 					unsigned int offset)
 {
@@ -80,7 +71,6 @@ static int gpio_lmux_probe(struct platform_device *pdev)
 	glm->gc.parent = dev;
 
 	glm->gc.get = gpio_lmux_gpio_get;
-	glm->gc.set = gpio_lmux_gpio_set;
 	glm->gc.get_direction = gpio_lmux_gpio_get_direction;
 
 	glm->mux = devm_mux_control_get(dev, NULL);
-- 
2.47.3