linux-kernel - Re: [PATCH] hpsa: fix a memory leak in hpsa_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026010718-upchuck-nimbly-6ffb@gregkh>
Date: Wed, 7 Jan 2026 10:06:41 +0100
From: Greg KH <greg@...ah.com>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: James.Bottomley@...senpartnership.com, don.brace@...rochip.com,
	martin.petersen@...cle.com, jbottomley@...allels.com,
	scameron@...rdog.cce.hp.com, storagedev@...rochip.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] hpsa: fix a memory leak in hpsa_find_cfgtables()

On Wed, Jan 07, 2026 at 04:56:17PM +0800, Haoxiang Li wrote:
> If write_driver_ver_to_cfgtable() fails, add iounmap() to
> release the memory allocated by remap_pci_mem().

How did you find this bug?  You always need to document the tool you are
using.

> 
> Fixes: 580ada3c1e2f ("[SCSI] hpsa: do a better job of detecting controller reset failure")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
> ---
>  drivers/scsi/hpsa.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 3654b12c5d5a..4cc129d2d6f2 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -7646,8 +7646,11 @@ static int hpsa_find_cfgtables(struct ctlr_info *h)
>  		return -ENOMEM;
>  	}
>  	rc = write_driver_ver_to_cfgtable(h->cfgtable);
> -	if (rc)
> +	if (rc) {
> +		iounmap(h->cfgtable);
> +		h->cfgtable = NULL;

Shouldn't you just call hpsa_free_cfgtables() instead?

thanks,

greg k-h