linux-kernel - Re: [PATCH for 6.19-rc1] fs: preserve file type in make_bad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jnqcwa3el6tlsgfd65tpcprjjdonj5xd4c44w5wfout7t2l5nb@obmys6lmhaid>
Date: Wed, 7 Jan 2026 11:15:58 +0100
From: Jan Kara <jack@...e.cz>
To: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc: Jan Kara <jack@...e.cz>, Jens Axboe <axboe@...nel.dk>, 
	Raphael Pinsonneault-Thibeault <rpthibeault@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for 6.19-rc1] fs: preserve file type in make_bad_inode()
 unless invalid

On Wed 07-01-26 18:53:40, Tetsuo Handa wrote:
> On 2026/01/07 18:36, Jan Kara wrote:
> > Since Jens has picked up
> > https://lore.kernel.org/all/20251217190040.490204-2-rpthibeault@gmail.com/
> > yesterday I suspect the original reproducer for OCFS2 will not cause issue
> > anymore even without 58b6fcd2ab34 because as far as I had a look the
> > original problem was caused by the loop device getting messed up under a
> > mounted OCFS2 filesystem. It would be good to verify my analysis is correct
> > but I think just reverting 58b6fcd2ab34 might be the best option at this
> > point.
> 
> Well, that patch wants
> 
>   	err = mutex_lock_killable(&lo->lo_mutex);
> - 	if (err)
> + 	if (err) {
> +		if (!(mode & BLK_OPEN_EXCL))
> +			bd_abort_claiming(bdev, loop_set_status);
>   		return err;
> +	}
> 
> change...

Ah, a good catch! Please send a fixup to Jens. Thanks!

								Honza

-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR