linux-kernel - Re: [PATCH v2] nvme/host: fixup some typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7db5ef3b6980270c948f6bd5dd9685e15493302c.camel@wdc.com>
Date: Wed, 7 Jan 2026 10:33:37 +0000
From: Wilfred Mallawa <wilfred.mallawa@....com>
To: hch <hch@....de>
CC: "kbusch@...nel.org" <kbusch@...nel.org>, "dlemoal@...nel.org"
	<dlemoal@...nel.org>, "axboe@...nel.dk" <axboe@...nel.dk>, "sagi@...mberg.me"
	<sagi@...mberg.me>, "linux-nvme@...ts.infradead.org"
	<linux-nvme@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] nvme/host: fixup some typos

On Wed, 2026-01-07 at 11:09 +0100, Christoph Hellwig wrote:
> Bit: the subject prefix is we usually use is just "nvme: ".
> 
> >  	/*
> >  	 * Handle ioctls that apply to the controller instead of
> > the namespace
> > -	 * separately and drop the ns SRCU reference early.  This
> > avoids a
> > +	 * separately and drop the ns SRCU reference early. This
> > avoids a
> 
> I don't see a typo here, just a reformatting to a different comment
> style not very commonly used in the nvme code.

It's just the extra white space before the "This avoids". Is that not a
typo?

> 
> > -/* Define the socket priority to use for connections were it is
> > desirable
> > +/* Define the socket priority to use for connections where it is
> > desirable
> 
> The change looks good, but if you touch this, you might as well fix
> up
> the comment style to match the normal kernel style:
> 
> /*
>  * Define the socket priority to use for connections where it is
> desirable

Ah no worries, will fixup!

Wilfred