linux-kernel - [PATCH] loop: add missing bd_abort_claiming in loop_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb9229f1-5472-4221-89d4-4df31bee8488@I-love.SAKURA.ne.jp>
Date: Wed, 7 Jan 2026 19:41:43 +0900
From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To: Jens Axboe <axboe@...nel.dk>,
        Raphael Pinsonneault-Thibeault <rpthibeault@...il.com>,
        Jan Kara <jack@...e.cz>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] loop: add missing bd_abort_claiming in loop_set_status

Commit 08e136ebd193 ("loop: don't change loop device under exclusive
opener in loop_set_status") forgot to call bd_abort_claiming() when
mutex_lock_killable() failed.

Fixes: 08e136ebd193 ("loop: don't change loop device under exclusive opener in loop_set_status")
Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
---
Since that commit for some reason calls loop_reread_partitions() when
bd_prepare_to_claim() failed, this patch calls loop_reread_partitions()
when mutex_lock_killable() failed after bd_abort_claiming()...
Maybe we should return as soon as possible?

 drivers/block/loop.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index ca74cc31bf07f..bd59c0e9508b7 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1245,7 +1245,8 @@ loop_set_status(struct loop_device *lo, blk_mode_t mode,
 
 	err = mutex_lock_killable(&lo->lo_mutex);
 	if (err)
-		return err;
+		goto out_abort_claiming;
+
 	if (lo->lo_state != Lo_bound) {
 		err = -ENXIO;
 		goto out_unlock;
@@ -1284,6 +1285,7 @@ loop_set_status(struct loop_device *lo, blk_mode_t mode,
 	}
 out_unlock:
 	mutex_unlock(&lo->lo_mutex);
+out_abort_claiming:
 	if (!(mode & BLK_OPEN_EXCL))
 		bd_abort_claiming(bdev, loop_set_status);
 out_reread_partitions:
-- 
2.47.3