linux-kernel - Re: [PATCH v2] regmap: Fix race condition in hwspinlock irqsave routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96e4fa72-b9cf-4c7c-9485-a95f4903cdb6@sirena.org.uk>
Date: Wed, 7 Jan 2026 11:28:34 +0000
From: Mark Brown <broonie@...nel.org>
To: Yu-Chun Lin <eleanor.lin@...ltek.com>
Cc: gregkh@...uxfoundation.org, rafael@...nel.org, dakr@...nel.org,
	baolin.wang@...ux.alibaba.com, cylee12@...ltek.com,
	linux-kernel@...r.kernel.org, james.tai@...ltek.com,
	cy.huang@...ltek.com, stanley_chang@...ltek.com
Subject: Re: [PATCH v2] regmap: Fix race condition in hwspinlock irqsave
 routine

On Wed, Jan 07, 2026 at 11:26:10AM +0800, Yu-Chun Lin wrote:

> v2:
>  - Initialize 'flags' to 0. This fixes a -Werror build failure when
>    CONFIG_HWSPINLOCK is disabled, as the stub function in that case does
>    not initialize the pointer.

>  {
>  	struct regmap *map = __map;
> +	unsigned long flags;
>  
>  	hwspin_lock_timeout_irqsave(map->hwlock, UINT_MAX,
> -				    &map->spinlock_flags);
> +				    &flags);
> +	map->spinlock_flags = flags;

I'm not seeing that initialisation in the actual patch?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)