linux-kernel - Re: [PATCH v2] perf build: Raise minimum shellcheck version to 0.7.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260107-pristine-flamingo-of-painting-0f3051@l-nschier-aarch64>
Date: Wed, 7 Jan 2026 12:53:07 +0100
From: Nicolas Schier <n.schier@....de>
To: Arnaldo Melo <arnaldo.melo@...il.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@...aro.org>,
	Michael Petlan <mpetlan@...hat.com>,
	Jakub Brnak <jbrnak@...hat.com>,
	Veronika Molnarova <vmolnaro@...hat.com>,
	Philipp Hahn <p.hahn@....de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nicolas Schier <nsc@...nel.org>
Subject: Re: [PATCH v2] perf build: Raise minimum shellcheck version to 0.7.2

On Wed, Jan 07, 2026 at 08:05:21AM -0300, Arnaldo Melo wrote:
> On January 7, 2026 5:13:26 AM GMT-03:00, Nicolas Schier <n.schier@....de> wrote:
> >Raise the minimum shellcheck version for perf builds to 0.7.2, so that
> >systems with shellcheck versions below 0.7.2 will automatically skip the
> >shell script checking, even if NO_SHELLCHECK is unset.
> >
> >Since commit 241f21be7d0f ("perf test perftool_testsuite: Use absolute
> >paths"), shellcheck versions before 0.7.2 break the perf build with
> >several SC1090 [2] warnings due to its too strict dynamic source
> >handling [1], e.g.:
> >
> >  In tests/shell/base_probe/test_line_semantics.sh line 20:
> >  . "$DIR_PATH/../common/init.sh"
> >    ^---------------------------^ SC1090: Can't follow non-constant source. Use a directive to specify location.
> >
> >Fixes: 241f21be7d0f ("perf test perftool_testsuite: Use absolute paths")
> >Link: https://github.com/koalaman/shellcheck/issues/1998 # [1]
> >Link: https://www.shellcheck.net/wiki/SC1090
> >Acked-by: Namhyung Kim <namhyung@...nel.org>
> >Signed-off-by: Nicolas Schier <n.schier@....de>
> >---
> >Changes in v2:
> >  * Add one of the shellcheck messages to commit message (Namhyung Kim)
> >  * Link to v1: https://lore.kernel.org/r/20260106-perf-raise-minimum-shellcheck-version-v1-1-b46739a78888@avm.de
> >---
> > tools/perf/Makefile.perf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> >index b3f481a626afa314632876449a11eb79b2978824..e2d668fb7f439befd6d1d9cbf66765f8b815e3c6 100644
> >--- a/tools/perf/Makefile.perf
> >+++ b/tools/perf/Makefile.perf
> >@@ -255,7 +255,7 @@ endif
> > # minimal shellcheck version as v0.6.0.
> 
> I'm looking just add this patch, from the smartphone, but shouldn't the above comment need to be updated as well?

ups.  Yes, sure; thanks for spotting.  I'll send a v3 tomorrow.

Kind regards,
Nicolas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)