linux-kernel - Re: [PATCH 3/3] clk: qcom: dispcc-sm7150: Fix dispcc_mdss_pclk0_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bbcbb227-7dd4-45dd-93a9-023ac445f4c0@ixit.cz>
Date: Wed, 7 Jan 2026 12:50:45 +0100
From: David Heidelberg <david@...t.cz>
To: Jens Reidel <adrian@...nlining.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Danila Tikhonov <danila@...xyga.com>,
 David Wronek <david@...nlining.org>, Petr Hodina <phodina@...tonmail.com>,
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 phone-devel@...r.kernel.org, linux@...nlining.org,
 ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 3/3] clk: qcom: dispcc-sm7150: Fix
 dispcc_mdss_pclk0_clk_src

On 19/09/2025 14:34, Jens Reidel wrote:
> Set CLK_OPS_PARENT_ENABLE to ensure the parent gets prepared and enabled
> when switching to it, fixing an "rcg didn't update its configuration"
> warning.
> 
> Signed-off-by: Jens Reidel <adrian@...nlining.org>
> ---
>   drivers/clk/qcom/dispcc-sm7150.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/dispcc-sm7150.c b/drivers/clk/qcom/dispcc-sm7150.c
> index 0a7f6ec7a2a737c6f6f0484c71dd80f3dbf758b6..811d380a8e9f9bd8a8f1aecba567ebffdb893f5d 100644
> --- a/drivers/clk/qcom/dispcc-sm7150.c
> +++ b/drivers/clk/qcom/dispcc-sm7150.c
> @@ -357,7 +357,7 @@ static struct clk_rcg2 dispcc_mdss_pclk0_clk_src = {
>   		.name = "dispcc_mdss_pclk0_clk_src",
>   		.parent_data = dispcc_parent_data_4,
>   		.num_parents = ARRAY_SIZE(dispcc_parent_data_4),
> -		.flags = CLK_SET_RATE_PARENT,
> +		.flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE,
>   		.ops = &clk_pixel_ops,
>   	},
>   };
> 

Hello Jens,

do you know if in the addition to dispcc_mdss_pclk0_clk_src 
pclk1_clk_src may need  this flag too?

We sent similar patch for sdm845 with both receiving 
CLK_OPS_PARENT_ENABLE, as some sdm845/sm7150 device may have two DSI.

What do you think?

David

P.S. Added +Petr and +Konrad to Cc.