linux-kernel - Re: [PATCH 2/5] lib/string_kunit: add test case for strnlen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfxT+K1QRc5ayZGc4joB9vFJrk7kjQ4gAgUHOT1boFbmA@mail.gmail.com>
Date: Wed, 7 Jan 2026 13:56:18 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Feng Jiang <jiangfeng@...inos.cn>
Cc: pjw@...nel.org, palmer@...belt.com, aou@...s.berkeley.edu, alex@...ti.fr, 
	kees@...nel.org, andy@...nel.org, ebiggers@...nel.org, 
	martin.petersen@...cle.com, Jason@...c4.com, conor.dooley@...rochip.com, 
	samuel.holland@...ive.com, charlie@...osinc.com, ajones@...tanamicro.com, 
	nathan@...nel.org, linus.walleij@...aro.org, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 2/5] lib/string_kunit: add test case for strnlen

On Wed, Jan 7, 2026 at 4:35 AM Feng Jiang <jiangfeng@...inos.cn> wrote:
>
> Add a KUnit test for strnlen() to verify correctness across
> different string lengths and memory alignments.

Same comment as per patch 1 (it would probably require to call for
arch_strnlen() or something like this).

...

> +       for (offset = 0; offset < 16; offset++) {
> +               for (len = 0; len <= 128; len++) {

You want to define these two limits to avoid the possible issues in
the future if the code gets changed.

> +       }

-- 
With Best Regards,
Andy Shevchenko