linux-kernel - Re: [PATCH v2] drm/radeon: convert VCE logging to drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6bd1fdd-fae7-4ee9-ae06-9abe168adbd4@amd.com>
Date: Wed, 7 Jan 2026 13:28:29 +0100
From: Christian König <christian.koenig@....com>
To: Mukesh Ogare <mukeshogare871@...il.com>, alexander.deucher@....com,
 airlied@...il.com, simona@...ll.ch, amd-gfx@...ts.freedesktop.org
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/radeon: convert VCE logging to drm_* helpers

On 12/20/25 09:01, Mukesh Ogare wrote:
> Replace legacy DRM_ERROR() and DRM_INFO() logging in the VCE code
> with drm_err() and drm_info() helpers that take a struct drm_device.
> 
> Using drm_* logging provides proper device context in dmesg, which is
> important for systems with multiple DRM devices, and aligns the radeon
> driver with current DRM logging practices.
> 
> No functional change intended.

I agree that this should only be info level, but you turn an error level into an info level, so that is a functional change.

Please adjust the commit message accordingly.

Regards,
Christian.

> 
> Signed-off-by: Mukesh Ogare <mukeshogare871@...il.com>
> ---
>  drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_vce.c b/drivers/gpu/drm/radeon/radeon_vce.c
> index a203992cb932..fd176034b251 100644
> --- a/drivers/gpu/drm/radeon/radeon_vce.c
> +++ b/drivers/gpu/drm/radeon/radeon_vce.c
> @@ -121,7 +121,7 @@ int radeon_vce_init(struct radeon_device *rdev)
>  	if (sscanf(c, "%2u]", &rdev->vce.fb_version) != 1)
>  		return -EINVAL;
>  
> -	drm_err(&rdev->ddev, "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
> +	drm_info(&rdev->ddev, "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
>  		 start, mid, end, rdev->vce.fb_version);
>  
>  	rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);