linux-kernel - Re: [PATCH v4 17/19] selftests: ublk: add integrity data support to loop target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV-mNgMwsYEMTLSW@fedora>
Date: Thu, 8 Jan 2026 20:42:30 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Jens Axboe <axboe@...nel.dk>, Shuah Khan <shuah@...nel.org>,
	linux-block@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Stanley Zhang <stazhang@...estorage.com>,
	Uday Shankar <ushankar@...estorage.com>,
	"Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v4 17/19] selftests: ublk: add integrity data support to
 loop target

On Thu, Jan 08, 2026 at 02:19:45AM -0700, Caleb Sander Mateos wrote:
> To perform and end-to-end test of integrity information through a ublk
> device, we need to actually store it somewhere and retrieve it. Add this
> support to kublk's loop target. It uses a second backing file for the
> integrity data corresponding to the data stored in the first file.
> The integrity file is initialized with byte 0xFF, which ensures the app
> and reference tags are set to the "escape" pattern to disable the
> bio-integrity-auto guard and reftag checks until the blocks are written.
> The integrity file is opened without O_DIRECT since it will be accessed
> at sub-block granularity. Each incoming read/write results in a pair of
> reads/writes, one to the data file, and one to the integrity file. If
> either backing I/O fails, the error is propagated to the ublk request.
> If both backing I/Os read/write some bytes, the ublk request is
> completed with the smaller of the number of blocks accessed by each I/O.
> 
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>

Reviewed-by: Ming Lei <ming.lei@...hat.com>

Thanks,
Ming