linux-kernel - Re: [PATCH v4 9/9] iio: adc: ad7380: add support for multiple SPI lanes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV-nJtPKWbmDSlah@debian-BULLSEYE-live-builder-AMD64>
Date: Thu, 8 Jan 2026 09:46:30 -0300
From: Marcelo Schmitt <marcelo.schmitt1@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Marcelo Schmitt <marcelo.schmitt@...log.com>,
	Michael Hennerich <michael.hennerich@...log.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Andy Shevchenko <andy@...nel.org>,
	Sean Anderson <sean.anderson@...ux.dev>, linux-spi@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org
Subject: Re: [PATCH v4 9/9] iio: adc: ad7380: add support for multiple SPI
 lanes

On 12/19, David Lechner wrote:
> Add support for multiple SPI lanes to increase throughput. The AD7380
> family of ADCs have multiple SDO lines on the chip that can be used to
> read each channel on a separate SPI lane. If wired up to a SPI
> controller that supports it, the driver will now take advantage of this
> feature. This allows reaching the maximum sample rate advertised in the
> datasheet when combined with SPI offloading.
> 
> Reviewed-by: Nuno Sá <nuno.sa@...log.com>
> Signed-off-by: David Lechner <dlechner@...libre.com>
> ---
...
>  	st->sample_freq_range[0] = 1; /* min */
>  	st->sample_freq_range[1] = 1; /* step */
> @@ -1887,6 +1899,11 @@ static int ad7380_probe(struct spi_device *spi)
>  	if (!st->chip_info)
>  		return dev_err_probe(dev, -EINVAL, "missing match data\n");
>  
> +	st->num_sdo_lines = spi->num_rx_lanes;
> +
> +	if (st->num_sdo_lines < 1 || st->num_sdo_lines > st->chip_info->num_simult_channels)
> +		return dev_err_probe(dev, -EINVAL, "invalid number of SDO lines\n");
> +
Maybe also print st->num_sdo_lines here?

Nevertheless,
Reviewed-by: Marcelo Schmitt <marcelo.schmitt@...log.com>

>  	ret = devm_regulator_bulk_get_enable(dev, st->chip_info->num_supplies,
>  					     st->chip_info->supplies);
>