linux-kernel - Re: [PATCH v5 03/13] dmaengine: axi-dmac: use sg_nents_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2713df7f8cb520f3ffbc783a9166499db13bb15.camel@gmail.com>
Date: Thu, 08 Jan 2026 13:40:18 +0000
From: Nuno Sá <noname.nuno@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Bjorn Andersson	
 <andersson@...nel.org>, Nuno Sá <nuno.sa@...log.com>, 
 Vinod Koul <vkoul@...nel.org>, Bartosz Golaszewski <brgl@...nel.org>,
 Thomas Andreatta	 <thomasandreatta2000@...il.com>, Caleb Sander Mateos
 <csander@...estorage.com>, 	dmaengine@...r.kernel.org,
 linux-kernel@...r.kernel.org, 	linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, 	linux-arm-msm@...r.kernel.org
Cc: Olivier Dautricourt <olivierdautricourt@...il.com>, Stefan Roese	
 <sr@...x.de>, Florian Fainelli <florian.fainelli@...adcom.com>, Broadcom
 internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Ray
 Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,  Lars-Peter
 Clausen	 <lars@...afoo.de>, Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
 Daniel Mack	 <daniel@...que.org>, Haojian Zhuang
 <haojian.zhuang@...il.com>, Robert Jarzmik	 <robert.jarzmik@...e.fr>, Lizhi
 Hou <lizhi.hou@....com>, Brian Xu	 <brian.xu@....com>, Raj Kumar Rampelli
 <raj.kumar.rampelli@....com>, Michal Simek <michal.simek@....com>, Andrew
 Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v5 03/13] dmaengine: axi-dmac: use sg_nents_for_dma()
 helper

On Thu, 2026-01-08 at 11:50 +0100, Andy Shevchenko wrote:
> Instead of open coded variant let's use recently introduced helper.
> 
> Reviewed-by: Bjorn Andersson <andersson@...nel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

>  drivers/dma/dma-axi-dmac.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 045e9b9a90df..f5caf75dc0e7 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -677,10 +677,7 @@ static struct dma_async_tx_descriptor *axi_dmac_prep_slave_sg(
>  	if (direction != chan->direction)
>  		return NULL;
>  
> -	num_sgs = 0;
> -	for_each_sg(sgl, sg, sg_len, i)
> -		num_sgs += DIV_ROUND_UP(sg_dma_len(sg), chan->max_length);
> -
> +	num_sgs = sg_nents_for_dma(sgl, sg_len, chan->max_length);
>  	desc = axi_dmac_alloc_desc(chan, num_sgs);
>  	if (!desc)
>  		return NULL;