linux-kernel - Re: [PATCH] block: initialize auto integrity buffer opaque

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260108135821.GA8886@lst.de>
Date: Thu, 8 Jan 2026 14:58:21 +0100
From: Christoph Hellwig <hch@....de>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: initialize auto integrity buffer opaque

The subject sounds a little weird.  From looking at the commit
message and the code change I'd expect it to be something like:

block: zero auto integrity buffer when not fully occupied by PI tuple

does that make sense?

> Switch the gfp_t variable to bool zero_buffer since it's only used to
> compute the zero_buffer argument to bio_integrity_alloc_buf().

Yeah, that also makes total sense now.  But maybe split it into a
separate cleanup patch to not detract from the bug fix?